-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8179503: Java should support GET OCSP calls #330
Conversation
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@apavlyutkin This change is no longer ready for integration - check the PR body for details. |
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Please don't close this, bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where the 'parity with Oracle' is coming from with this issue. The bug is an enhancement and only currently in 17.
I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first.
|
postponed until the seria gets into 11u |
Hi!
I would like to backport JDK-8179503: Java should support GET OCSP calls for parity with Oracle JDK.
Except the path suffling the following changes were done to original patch:
jdk/src/share/classes/sun/security/provider/certpath/OCSP.java
InputStream.read()
method becauseIOUtils.readExactlyNBytes()
is not availablejdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
List.of()
,Set.of()
,Map.of()
replaced with equivalentsalgorithm
parameter dropped from instantiationPKCS8EncodedKeySpec
jdk/test/javax/net/ssl/templates/SSLSocketTemplate.java
public static enum SSLSocketTemplate.Cert
copied from11u
Verification (amd64/20.04LTS): newly added
jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
Regression (amd64/20.04LTS):
jdk_security
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/330/head:pull/330
$ git checkout pull/330
Update a local copy of the PR:
$ git checkout pull/330
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/330/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 330
View PR using the GUI difftool:
$ git pr show -t 330
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/330.diff
Webrev
Link to Webrev Comment