Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179503: Java should support GET OCSP calls #330

Closed
wants to merge 2 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 5, 2023

Hi!

I would like to backport JDK-8179503: Java should support GET OCSP calls for parity with Oracle JDK.

Except the path suffling the following changes were done to original patch:

jdk/src/share/classes/sun/security/provider/certpath/OCSP.java

  • still reads the response piece by piece using InputStream.read() method because IOUtils.readExactlyNBytes() is not available

jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java

  • unsupported List.of(), Set.of(), Map.of() replaced with equivalents
  • algorithm parameter dropped from instantiation PKCS8EncodedKeySpec

jdk/test/javax/net/ssl/templates/SSLSocketTemplate.java

  • required public static enum SSLSocketTemplate.Cert copied from 11u

Verification (amd64/20.04LTS): newly added jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
Regression (amd64/20.04LTS): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8179503 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8179503: Java should support GET OCSP calls (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/330/head:pull/330
$ git checkout pull/330

Update a local copy of the PR:
$ git checkout pull/330
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 330

View PR using the GUI difftool:
$ git pr show -t 330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/330.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f5ee356540d7aa4a7663c0d5d74f5fdb0726b426 8179503: Java should support GET OCSP calls Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@apavlyutkin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin
Copy link
Contributor Author

Please don't close this, bot.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the 'parity with Oracle' is coming from with this issue. The bug is an enhancement and only currently in 17.

I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @apavlyutkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 28, 2023
@apavlyutkin
Copy link
Contributor Author

postponed until the seria gets into 11u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants