Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274471: Add support for RSASSA-PSS in OCSP Response #331

Closed
wants to merge 2 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 6, 2023

Hi!

I'd like to backport JDK-8274471: Add support for RSASSA-PSS in OCSP Response for parity with Oracle JDK.

The patch from 11u applied with the following changes (except the path shuffling):

jdk/src/share/classes/sun/security/provider/certpath/OCSP.java

  • URLEncoder.encode() accepts desired charset as a string, charset constants are not supported in 8, so import of java.nio.charset.StandardCharsets also skipped
  • resolved little baseline conflict

jdk/src/share/classes/sun/security/x509/AlgorithmId.java

  • required public static String getDefaultSigAlgForKey(PrivateKey k) and private static String ecStrength (int bitLength) copied from 11

Verification (amd64/20.04): jdk/test/javax/net/ssl/Stapling/HttpsUrlConnClient.java with new RSASSA-PSS case
Regression (amd64/20.04): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8274471 needs maintainer approval

Integration blocker

 ⚠️ Dependency #330 must be integrated first

Issue

  • JDK-8274471: Add support for RSASSA-PSS in OCSP Response (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/331/head:pull/331
$ git checkout pull/331

Update a local copy of the PR:
$ git checkout pull/331
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 331

View PR using the GUI difftool:
$ git pr show -t 331

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/331.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into pr/330 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f63c4a832a1aea451f47aaf86d5361e970c6a28f 8274471: Add support for RSASSA-PSS in OCSP Response Jun 6, 2023
@openjdk
Copy link

openjdk bot commented Jun 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin
Copy link
Contributor Author

Please don't close this, bot.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the dependency, I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants