-
Notifications
You must be signed in to change notification settings - Fork 171
8274471: Add support for RSASSA-PSS in OCSP Response #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Please don't close this, bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the dependency, I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first.
|
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi!
I'd like to backport JDK-8274471: Add support for RSASSA-PSS in OCSP Response for parity with Oracle JDK.
The patch from
11uapplied with the following changes (except the path shuffling):jdk/src/share/classes/sun/security/provider/certpath/OCSP.javaURLEncoder.encode()accepts desired charset as a string, charset constants are not supported in8, so import ofjava.nio.charset.StandardCharsetsalso skippedjdk/src/share/classes/sun/security/x509/AlgorithmId.javapublic static String getDefaultSigAlgForKey(PrivateKey k)andprivate static String ecStrength (int bitLength)copied from11Verification (amd64/20.04):
jdk/test/javax/net/ssl/Stapling/HttpsUrlConnClient.javawith newRSASSA-PSScaseRegression (amd64/20.04):
jdk_securityProgress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/331/head:pull/331$ git checkout pull/331Update a local copy of the PR:
$ git checkout pull/331$ git pull https://git.openjdk.org/jdk8u-dev.git pull/331/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 331View PR using the GUI difftool:
$ git pr show -t 331Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/331.diff
Webrev
Link to Webrev Comment