Skip to content

Conversation

@Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Jul 25, 2023

This backport fixes the tier2 test:
FAILED: java/net/MulticastSocket/JoinLeave.java -- The socket name is not available on this system. (Error setting socket option)

Changes are applied non-cleanly.
Tested on AIX 7.2


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8207404 needs maintainer approval

Issue

  • JDK-8207404: MulticastSocket tests failing on AIX (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/347/head:pull/347
$ git checkout pull/347

Update a local copy of the PR:
$ git checkout pull/347
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 347

View PR using the GUI difftool:
$ git pr show -t 347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/347.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2023

👋 Welcome back inakonechnyy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bc651663e31ddf05d59bfe6fc7a70c3a7ed708af 8207404: MulticastSocket tests failing on AIX Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Aug 9, 2023

Please enable GHA on your fork and trigger a test run with this.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

@Larry-N This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Larry-N
Copy link
Contributor Author

Larry-N commented Sep 8, 2023

The GHA was enabled, and all checks passed. Waiting for review

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8207404: MulticastSocket tests failing on AIX

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @Larry-N This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed ready Pull request is ready to be integrated labels Sep 28, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 11, 2023
@phohensee
Copy link
Member

Backport approved, please add /integrate.

@Larry-N
Copy link
Contributor Author

Larry-N commented Oct 16, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@Larry-N
Your change (at version 243ed39) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Contributor

yan-too commented Oct 16, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit edef564.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@yan-too @Larry-N Pushed as commit edef564.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants