Skip to content

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Apr 12, 2022

Major versions of GCC often cause problems with OpenJDK. Fedora's eager adoption of them means we often encounter these early. JDK-8282231 is just the latest example from the introduction of GCC 12.

However, the GHA workflow in OpenJDK doesn't just depend on a major version of GCC - which is actually contained in the Ubuntu package name of gcc-9 itself - but the full revision number, even down to local packaging changes.

I believe this is overkill and leads to valuable time being wasted on issues like JDK-8283778 where the GCC version itself didn't change at all, just the Ubuntu version suffix.

Rather than maintain this for 8u, I suggest we just depend on gcc-9 which is already a pretty modern version for 8u. I have yet to see an issue be specific to a minor GCC version bump, whereas the current setup is pretty much guaranteed to mean further fixes to the GitHub workflow every time the Ubuntu packager produces a new build.

Note that the x86-32 Linux build already uses just gcc-9-multilib which is why it hasn't been broken by the latest GCC update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284772: 8u GHA: Use GCC Major Version Dependencies Only

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/35.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@gnu-andrew gnu-andrew changed the title Remove specification of full package version from GCC dependency JDK-8284772: Remove specification of full package version from GCC dependency Apr 12, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2022
@gnu-andrew gnu-andrew changed the title JDK-8284772: Remove specification of full package version from GCC dependency JDK-8284772: 8u GHA: Use GCC Major Version Dependencies Only Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

@RealCLanger
Copy link
Contributor

I would really love to see this type of change be done in jdk head and be backported to each active update release 😄

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284772: 8u GHA: Use GCC Major Version Dependencies Only

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2022
@gnu-andrew
Copy link
Member Author

Thanks @mrserb. I've flagged this for 8u approval.

@gnu-andrew
Copy link
Member Author

I see jdk8u-fix-yes.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

Going to push as commit 62defc3.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2022
@openjdk openjdk bot closed this Apr 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@gnu-andrew Pushed as commit 62defc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants