-
Notifications
You must be signed in to change notification settings - Fork 171
JDK-8284772: 8u GHA: Use GCC Major Version Dependencies Only #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
I would really love to see this type of change be done in jdk head and be backported to each active update release 😄 |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks @mrserb. I've flagged this for 8u approval. |
|
I see |
|
/integrate |
|
Going to push as commit 62defc3.
Your commit was automatically rebased without conflicts. |
|
@gnu-andrew Pushed as commit 62defc3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Major versions of GCC often cause problems with OpenJDK. Fedora's eager adoption of them means we often encounter these early. JDK-8282231 is just the latest example from the introduction of GCC 12.
However, the GHA workflow in OpenJDK doesn't just depend on a major version of GCC - which is actually contained in the Ubuntu package name of
gcc-9itself - but the full revision number, even down to local packaging changes.I believe this is overkill and leads to valuable time being wasted on issues like JDK-8283778 where the GCC version itself didn't change at all, just the Ubuntu version suffix.
Rather than maintain this for 8u, I suggest we just depend on
gcc-9which is already a pretty modern version for 8u. I have yet to see an issue be specific to a minor GCC version bump, whereas the current setup is pretty much guaranteed to mean further fixes to the GitHub workflow every time the Ubuntu packager produces a new build.Note that the x86-32 Linux build already uses just
gcc-9-multilibwhich is why it hasn't been broken by the latest GCC update.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/35/head:pull/35$ git checkout pull/35Update a local copy of the PR:
$ git checkout pull/35$ git pull https://git.openjdk.java.net/jdk8u-dev pull/35/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 35View PR using the GUI difftool:
$ git pr show -t 35Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/35.diff