-
Notifications
You must be signed in to change notification settings - Fork 171
8210560: [TEST] convert com/sun/jdi redefineClass-related tests #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Could someone please review this backport? |
|
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@ktakakuri this pull request can not be integrated into git checkout 8210560
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
This seems to include both 8210560 & 8209109. |
|
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@ktakakuri This pull request is now open |
|
❗ This change is not yet ready to be integrated. |
|
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Indeed, this pull request includes some bug IDs. |
This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.
Original patch does not apply cleanly to 8u, because:
So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.
I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/350/head:pull/350$ git checkout pull/350Update a local copy of the PR:
$ git checkout pull/350$ git pull https://git.openjdk.org/jdk8u-dev.git pull/350/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 350View PR using the GUI difftool:
$ git pr show -t 350Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/350.diff
Webrev
Link to Webrev Comment