Skip to content

Conversation

@ktakakuri
Copy link
Member

@ktakakuri ktakakuri commented Aug 3, 2023

This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.

Original patch does not apply cleanly to 8u, because:

  1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib.
  2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager).

So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.

I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8210560 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with updated jcheck configuration in pull request)

Issue

  • JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/350.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2023

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0b3f46efe1db4516949d12a7bdfe67d4ca5eddef 8210560: [TEST] convert com/sun/jdi redefineClass-related tests Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 3, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Member Author

Could someone please review this backport?

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@ktakakuri this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8210560
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Nov 13, 2023
@gnu-andrew
Copy link
Member

This seems to include both 8210560 & 8209109.
Can we please do 8209109 separately first? It is difficult to review this when the backport does not align with the version in 11u & trunk. Thanks.
Incidentally, the version of CompilerUtils.java that couldn't be compiled has now been removed by JDK-8305329

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Feb 1, 2024
@ktakakuri
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@ktakakuri This pull request is now open

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Member Author

Indeed, this pull request includes some bug IDs.
I close this pull request to backport each bug ID separately.

@ktakakuri ktakakuri closed this Apr 17, 2024
@ktakakuri ktakakuri deleted the 8210560 branch April 17, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants