Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value #352

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link
Contributor

@benty-amzn benty-amzn commented Aug 4, 2023

Backporting https://bugs.openjdk.org/browse/JDK-8206179 for parity with Oracle 8u.

Backport is clean, copyright was manually resolved.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/352/head:pull/352
$ git checkout pull/352

Update a local copy of the PR:
$ git checkout pull/352
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 352

View PR using the GUI difftool:
$ git pr show -t 352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/352.diff

Webrev

Link to Webrev Comment

…MemorySize.java fails with Committed virtual memory size illegal value

Reviewed-by: sspitsyn, cjplummer
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ea3869a926003cd3cebd3d8ecf9657646bdbda3 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport is clean, bar the copyright header.

Does the test pass on 8u when run standalone? The bug suggests it's part of tier5, not tier1.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@benty-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

Reviewed-by: andrew, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 23, 2023
@benty-amzn
Copy link
Contributor Author

Re-tested and confirmed the test passes when run standalone on linux x64

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approved for 8u.

@benty-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@benty-amzn
Your change (at version 9c5f924) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit bbc068f.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@phohensee @benty-amzn Pushed as commit bbc068f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants