-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value #352
Conversation
…MemorySize.java fails with Committed virtual memory size illegal value Reviewed-by: sspitsyn, cjplummer
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport is clean, bar the copyright header.
Does the test pass on 8u when run standalone? The bug suggests it's part of tier5, not tier1.
@benty-amzn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Re-tested and confirmed the test passes when run standalone on linux x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Approved for 8u.
/integrate |
@benty-amzn |
/sponsor |
Going to push as commit bbc068f.
Your commit was automatically rebased without conflicts. |
@phohensee @benty-amzn Pushed as commit bbc068f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting https://bugs.openjdk.org/browse/JDK-8206179 for parity with Oracle 8u.
Backport is clean, copyright was manually resolved.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/352/head:pull/352
$ git checkout pull/352
Update a local copy of the PR:
$ git checkout pull/352
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/352/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 352
View PR using the GUI difftool:
$ git pr show -t 352
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/352.diff
Webrev
Link to Webrev Comment