Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors #353

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Aug 12, 2023

This is a follow-up fix for JDK-6722928.
Clean backport from JDK11


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/353.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2023

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e03c2a270b291e7b1edcf4df491d6d386a882a87 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors Aug 12, 2023
@openjdk
Copy link

openjdk bot commented Aug 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 12, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2023

Webrevs

@gnu-andrew
Copy link
Member

Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble.

@alexeybakhtin
Copy link
Contributor Author

Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble.

Sure, just made a PR against openjdk/jdk8u

@jerboaa
Copy link
Contributor

jerboaa commented Sep 5, 2023

@alexeybakhtin Please close this in favor of openjdk/jdk8u#47

@alexeybakhtin
Copy link
Contributor Author

Sure. Review moved to openjdk/jdk8u#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants