-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion #354
Conversation
Reviewed-by: jdv, dnguyen
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean Only the patch of the test is changed. |
@mrserb This backport pull request is now marked as clean |
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivially clean backport as it introduces a new test file, so only path adjustment is needed.
Approving on the assumption this does pass on 8u.
/integrate |
Going to push as commit 79cae43.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit abeddab9 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/354/head:pull/354
$ git checkout pull/354
Update a local copy of the PR:
$ git checkout pull/354
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 354
View PR using the GUI difftool:
$ git pr show -t 354
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/354.diff
Webrev
Link to Webrev Comment