Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion #354

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 12, 2023

Hi all,
This pull request contains a backport of commit abeddab9 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/354/head:pull/354
$ git checkout pull/354

Update a local copy of the PR:
$ git checkout pull/354
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 354

View PR using the GUI difftool:
$ git pr show -t 354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/354.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review August 12, 2023 01:12
@mrserb mrserb changed the title 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Backport-of: abeddab991d71f4ea54665082ffcb284267d7f44 Aug 12, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2023
@mrserb mrserb changed the title Backport-of: abeddab991d71f4ea54665082ffcb284267d7f44 Backport abeddab991d71f4ea54665082ffcb284267d7f44 Aug 12, 2023
@openjdk openjdk bot changed the title Backport abeddab991d71f4ea54665082ffcb284267d7f44 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Aug 12, 2023
@openjdk
Copy link

openjdk bot commented Aug 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 12, 2023
@mrserb
Copy link
Member Author

mrserb commented Aug 12, 2023

/clean Only the patch of the test is changed.

@openjdk openjdk bot added the clean label Aug 12, 2023
@openjdk
Copy link

openjdk bot commented Aug 12, 2023

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Aug 12, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3232400: 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal
  • fc37942: 8287663: Add a regression test for JDK-8287073

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2023

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivially clean backport as it introduces a new test file, so only path adjustment is needed.

Approving on the assumption this does pass on 8u.

@mrserb
Copy link
Member Author

mrserb commented Aug 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit 79cae43.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f929269: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field"
  • aa3e9dd: 8202952: C2: Unexpected dead nodes after matching
  • 3232400: 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal
  • fc37942: 8287663: Add a regression test for JDK-8287073

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@mrserb Pushed as commit 79cae43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-6528710 branch August 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants