-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal #355
Conversation
…5573/SortMethodsTest.java removal Removed runtime/6925573/SortMethodsTest.java from TEST.groups Reviewed-by: gtriantafill, lfoltan, coleenp, dholmes
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
@benty-amzn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've also approved the bug for 8u.
/integrate |
@benty-amzn |
/sponsor |
Going to push as commit 3232400. |
@phohensee @benty-amzn Pushed as commit 3232400. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport JDK-8042726 as a follow-up to #351, to resolve a bug in that backport. Change has merge conflicts due to changes in context line, but the change itself is clean as it is a single-line deletion.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/355/head:pull/355
$ git checkout pull/355
Update a local copy of the PR:
$ git checkout pull/355
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/355/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 355
View PR using the GUI difftool:
$ git pr show -t 355
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/355.diff
Webrev
Link to Webrev Comment