-
Notifications
You must be signed in to change notification settings - Fork 171
8285398: Cache the results of constraint checks #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@alexeybakhtin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
|
|
@alexeybakhtin This seems OK. Please create a PR with the follow-up so that both can be approved together. Thanks! |
|
/integrate |
|
Going to push as commit bbf2e9a.
Your commit was automatically rebased without conflicts. |
|
@alexeybakhtin Pushed as commit bbf2e9a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport applies almost cleanly.
Small merge fixes in the import section caused by JDK-8280890 (already applied in 8u) and JDK-8233228 (applied differently than in 11u)
No regression in jtreg tests
Follow-up JDK-8285696 fix should be applied
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/356/head:pull/356$ git checkout pull/356Update a local copy of the PR:
$ git checkout pull/356$ git pull https://git.openjdk.org/jdk8u-dev.git pull/356/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 356View PR using the GUI difftool:
$ git pr show -t 356Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/356.diff
Webrev
Link to Webrev Comment