Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Sep 5, 2023

Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u. Patch applies cleanly after path shuffling and backporting JDK-8295894. See #363

Testing:


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314960: Add Certigna Root CA - 2 (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/366/head:pull/366
$ git checkout pull/366

Update a local copy of the PR:
$ git checkout pull/366
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 366

View PR using the GUI difftool:
$ git pr show -t 366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/366.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/363 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0 8314960: Add Certigna Root CA - 2 Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 5, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/363 to master September 6, 2023 09:36
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 6, 2023

Replaced by: openjdk/jdk8u#49

@jerboaa jerboaa closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant