8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set #368

jerboaa · 2023-09-06T13:50:09Z

Simple GHA only change to add cacert tests to the tier1 test set. Please review.

Testing:

GHA (including the new CA certs tests).

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8315757 needs maintainer approval

Issue

JDK-8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set (Bug - P3 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 8a78c6a9
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368
$ git checkout pull/368

Update a local copy of the PR:
$ git checkout pull/368
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 368

View PR using the GUI difftool:
$ git pr show -t 368

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/368.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-06T13:51:22Z

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/365 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2023-09-06T14:53:57Z

Webrevs

phohensee

This seems to include the changes from #365. Maybe forgot to derive your 8315757 branch from your 8309088 branch?

openjdk · 2023-09-08T09:15:35Z

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

jerboaa · 2023-09-08T09:17:37Z

This seems to include the changes from #365. Maybe forgot to derive your 8315757 branch from your 8309088 branch?

It's an oddity of dependent pull requests. As soon as one of the PRs you depend on integrate, you need to rebase to the actually committed/rebased version in all dependants. Should be fixed now.

phohensee

Fixed. :)

gnu-andrew

There's already a jdk_security_infra so should we not reuse that, either adding cacerts to it or including it in jdk_cacerts?

Also, why is this not being proposed to trunk first?

gnu-andrew · 2023-09-08T18:13:16Z

On the positive side, the checks show it is working :)

openjdk-notifier · 2023-09-11T08:21:27Z

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8315757-tier1-gha
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2023-09-11T08:22:19Z

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2023-09-11T08:41:40Z

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

jerboaa · 2023-09-11T08:51:20Z

There's already a jdk_security_infra so should we not reuse that, either adding cacerts to it or including it in jdk_cacerts?

Good catch. I've added it to jdk_security_infra.

Also, why is this not being proposed to trunk first?

VerifyCACerts.java is part of tier2 in JDK head by means of jdk_security => jdk_security_3 => sun/security. jdk_security_infra is not part of any group yet, which I assume has a reason. Probably, because those tests depend on what CAs do (external factors?). The situation in 8u is a bit different to later JDKs, IMO. It's more like GHA being the best option for the early heads-up in 8u as later tiers aren't being run publicly. I have no strong opinion about this, but I lack the relevant cycles in order to push this upstream at this point. Feel free to go ahead and propose it though.

gnu-andrew · 2023-09-11T16:20:31Z

There's already a jdk_security_infra so should we not reuse that, either adding cacerts to it or including it in jdk_cacerts?

Good catch. I've added it to jdk_security_infra.

It looks like it was added by JDK-8189131 but that didn't add it to any tier. It does seem worth investigating if this was just an oversight or intentional.

Also, why is this not being proposed to trunk first?

VerifyCACerts.java is part of tier2 in JDK head by means of jdk_security => jdk_security_3 => sun/security. jdk_security_infra is not part of any group yet, which I assume has a reason. Probably, because those tests depend on what CAs do (external factors?). The situation in 8u is a bit different to later JDKs, IMO. It's more like GHA being the best option for the early heads-up in 8u as later tiers aren't being run publicly. I have no strong opinion about this, but I lack the relevant cycles in order to push this upstream at this point. Feel free to go ahead and propose it though.

Ah ok, I hadn't realised 8u was running a smaller test set than later JDKs. I'm guessing later tiers don't pass? Given the cacerts part is a 8u-only omission, I'm happy for this to go in as is.

I think the infra story is worth pursuing upstream. I've no issue with adding them like this to 8u for now, under this ticket, so we have tests running in some form. However, we may need to adjust further, depending on the decision upstream.

Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

jerboaa · 2023-09-11T16:40:48Z

Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

It should pass once jdk8u merges with jdk8u-dev as we need JDK-8295894 in jdk8u-dev for this to be clean.

gnu-andrew · 2023-09-15T02:57:37Z

Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

It should pass once jdk8u merges with jdk8u-dev as we need JDK-8295894 in jdk8u-dev for this to be clean.

Ok that one's on me then. I'll get that merged and then you can merge this PR with the merged 8u-dev HEAD and run the tests.

gnu-andrew · 2023-09-20T23:40:28Z

8u392-b06 now merged back into 8u-dev (#375), so merging this with HEAD should re-run the tests with JDK-8295894.

jerboaa · 2023-09-21T07:42:00Z

Done. Lets see how it goes.

EDIT: Good times. Looks like by now one of the GoogleCA certs have been revoked:

 TEST: security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java
[...]
java.lang.RuntimeException: TEST FAILED: unexpected status of EE certificate
	at ValidatePathWithParams.validate(ValidatePathWithParams.java:193)
	at GoogleGSR4.runTest(GoogleCA.java:155)
	at GoogleCA.main(GoogleCA.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
	at java.lang.Thread.run(Thread.java:750)

gnu-andrew · 2023-09-26T23:14:03Z

Looks like this is JDK-8316215 and the solution seems to be to change the approach to this testing altogether; see JDK-8308592

gnu-andrew · 2023-09-27T17:12:04Z

I've started the backporting of that change with 17u: openjdk/jdk17u-dev#1805 Once it's in 8u, this should pass (fingers crossed)

openjdk · 2023-10-02T17:36:47Z

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk · 2023-11-28T09:45:45Z

@jerboaa This pull request is now open

jerboaa · 2023-11-28T09:46:06Z

This could work again once #390 is in. Waiting for that to happen first.

gnu-andrew · 2023-11-28T15:10:48Z

All tests pass now with #390, so if you make this PR depend on that, it should now pass.

openjdk · 2023-11-28T16:29:53Z

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

jerboaa · 2023-11-28T16:30:00Z

All tests pass now with #390, so if you make this PR depend on that, it should now pass.

Done. Let's see how it goes in terms of GHA.

openjdk-notifier · 2023-12-02T00:40:03Z

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8315757-tier1-gha
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2023-12-04T11:01:50Z

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

jerboaa · 2023-12-04T13:30:01Z

/approval request Please approve getting this 8u-specific test-only change in. It helps verify cacert issues. Risk is low, as it's a test only change. Should there be stability issues, tests could get problem-listed or disabled. GHA testing shows that those tests pass.

openjdk · 2023-12-04T13:32:14Z

@jerboaa
8315757: The approval request has been created successfully.

gnu-andrew

jdk tests finally passing (for the time being!)

gnu-andrew · 2023-12-05T16:17:34Z

/approve yes

openjdk · 2023-12-05T16:18:22Z

@gnu-andrew
8315757: The approval request has been approved.

jerboaa · 2023-12-05T16:33:53Z

Thanks for the review and approval!

/integrate

openjdk · 2023-12-05T16:34:48Z

Going to push as commit 74a3ddd.

openjdk · 2023-12-05T16:34:57Z

@jerboaa Pushed as commit 74a3ddd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

jerboaa mentioned this pull request Sep 6, 2023

8271838: AmazonCA.java interop test fails #364

Closed

2 tasks

openjdk-notifier bot force-pushed the pr/365 branch from a4d1230 to aff6171 Compare September 6, 2023 14:44

jerboaa marked this pull request as ready for review September 6, 2023 14:48

openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023

phohensee suggested changes Sep 7, 2023

View reviewed changes

jerboaa force-pushed the JDK-8315757-tier1-gha branch from c3f5e1d to 8a78c6a Compare September 8, 2023 09:15

phohensee approved these changes Sep 8, 2023

View reviewed changes

gnu-andrew reviewed Sep 8, 2023

View reviewed changes

openjdk-notifier bot changed the base branch from pr/365 to master September 11, 2023 08:21

openjdk bot added the ready Pull request is ready to be integrated label Sep 11, 2023

jerboaa force-pushed the JDK-8315757-tier1-gha branch from 8a78c6a to f66b60c Compare September 11, 2023 08:39

zhaosongzs mentioned this pull request Sep 28, 2023

2049: After enabled maintainer approval in a repo, some pull requests are not updated openjdk/skara#1563

Closed

2 tasks

openjdk bot removed the ready Pull request is ready to be integrated label Oct 2, 2023

openjdk bot reopened this Nov 28, 2023

jerboaa force-pushed the JDK-8315757-tier1-gha branch from 3bcf7e2 to e0584c3 Compare November 28, 2023 16:27

jerboaa changed the base branch from master to pr/390 November 28, 2023 16:27

openjdk-notifier bot changed the base branch from pr/390 to master December 2, 2023 00:39

jerboaa added 2 commits December 4, 2023 12:00

8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

78f38ac

Move to jdk_security_infra and add to tier1

411458a

jerboaa force-pushed the JDK-8315757-tier1-gha branch from e0584c3 to 411458a Compare December 4, 2023 11:01

openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 4, 2023

gnu-andrew approved these changes Dec 5, 2023

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 5, 2023

openjdk bot added the integrated Pull request has been integrated label Dec 5, 2023

openjdk bot closed this Dec 5, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2023

jerboaa mentioned this pull request Dec 5, 2023

8317373: Add Telia Root CA v2 #397

Closed

6 tasks

8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set #368

8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set #368

Uh oh!

Conversation

jerboaa commented Sep 6, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 6, 2023

Uh oh!

mlbridge bot commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

phohensee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 8, 2023

Uh oh!

jerboaa commented Sep 8, 2023

Uh oh!

phohensee left a comment

Choose a reason for hiding this comment

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

gnu-andrew commented Sep 8, 2023

Uh oh!

openjdk-notifier bot commented Sep 11, 2023

Uh oh!

openjdk bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 11, 2023

Uh oh!

jerboaa commented Sep 11, 2023

Uh oh!

gnu-andrew commented Sep 11, 2023

Uh oh!

jerboaa commented Sep 11, 2023

Uh oh!

gnu-andrew commented Sep 15, 2023

Uh oh!

gnu-andrew commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerboaa commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnu-andrew commented Sep 26, 2023

Uh oh!

gnu-andrew commented Sep 27, 2023

Uh oh!

openjdk bot commented Oct 2, 2023

Uh oh!

openjdk bot commented Nov 28, 2023

Uh oh!

jerboaa commented Nov 28, 2023

Uh oh!

gnu-andrew commented Nov 28, 2023

Uh oh!

openjdk bot commented Nov 28, 2023

Uh oh!

jerboaa commented Nov 28, 2023

Uh oh!

openjdk-notifier bot commented Dec 2, 2023

Uh oh!

openjdk bot commented Dec 4, 2023

Uh oh!

jerboaa commented Dec 4, 2023

Uh oh!

openjdk bot commented Dec 4, 2023

Uh oh!

gnu-andrew left a comment

jerboaa commented Sep 6, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 6, 2023 •

edited

Loading

phohensee left a comment •

edited

Loading

openjdk bot commented Sep 11, 2023 •

edited

Loading

gnu-andrew commented Sep 20, 2023 •

edited

Loading

jerboaa commented Sep 21, 2023 •

edited

Loading