Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8150669: C1 intrinsic for Class.isPrimitive #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Apr 19, 2022

Hi,

Please review this backport. The original purpose is to backport fix for JDK-8239477. But this depends on fix for JDK-8150669 & JDK-8233019.

Performed full jtreg test both on x86_64-linux-gnu and aarch64-linux-gnu platforms.

This PR has been reviewed by Paul and approved before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014155.html

Follow-up fix JDK-8233019 is planned to be backported as well.

(I made this PR on behalf of fyang)

Thanks,
hedongbo


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/jdk8u-dev pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/37.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2022

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 890f94d7e6be731ac2ebae2f1ad3cc20ec836115 8150669: C1 intrinsic for Class.isPrimitive Apr 19, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 19, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2022

Webrevs

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Apr 20, 2022

/reviewer add phh

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2022

@dongbohe Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

  • /reviewer credit @openjdk-bot
  • /reviewer credit duke
  • /reviewer credit @user1 @user2

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Apr 20, 2022

/reviewer credit phh

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2022

@dongbohe
Reviewer phh successfully credited.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2022

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2022

@dongbohe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 15, 2022
@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Jun 16, 2022

/open

@openjdk openjdk bot reopened this Jun 16, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2022

@dongbohe This pull request is now open

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2022

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8150669: C1 intrinsic for Class.isPrimitive

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready rfr
2 participants