8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

[kurashige23]

Hi,

This is a backoport of JDK-8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

Original patch does not apply cleanly to 8u, bacause "parent" is declared at XWindowPeer.java#1652 in 8u.
So I deleted that declaration.

There is a related Issue: JDK-8222323, and I submit the corresponding PR. Testing was done after applying this related patch.
Testing: jdk_awt on RHEL7, GHA testing

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8021961 needs maintainer approval

Issue

• JDK-8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios (Bug - P3 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/377/head:pull/377
$ git checkout pull/377

Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 377

View PR using the GUI difftool:
$ git pr show -t 377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/377.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (165bb7c2)

[kurashige23]

Could someone please review this backport?

[gnu-andrew]

It looks like the parent line was added to 8u for the backport of JDK-8187803, as it wasn't present due to this change (JDK-8021961) being absent. So replacing it with the earlier declaration in 8021961 seems correct.

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

@gnu-andrew
Thank you for your reviewing. I asked my colleague to add jdk8u-fix-request label. So please check it.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
• 2f81fb4: 8251551: Use .md filename extension for README
• b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
• 3b9c787: 8208655: use JTreg skipped status in hotspot tests
• 0464401: 8320713: Bump update version of OpenJDK: 8u412
• b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
• 10a653e: 8176509: Use pandoc for converting build readme to html
• 0e7ebcb: 8317291: Missing null check for nmethod::is_native_method()
• eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
• dd43bdd: 8319405: [s390] [jdk8] Increase javac default stack size for s390x zero
• ... and 21 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[phohensee]

This PR has been approved, please add /integrate.

[kurashige23]

/integrate

[openjdk]

@kurashige23
Your change (at version 165bb7c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 8cf7c96.
Since your change was applied there have been 31 commits pushed to the master branch:

• a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
• 2f81fb4: 8251551: Use .md filename extension for README
• b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
• 3b9c787: 8208655: use JTreg skipped status in hotspot tests
• 0464401: 8320713: Bump update version of OpenJDK: 8u412
• b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
• 10a653e: 8176509: Use pandoc for converting build readme to html
• 0e7ebcb: 8317291: Missing null check for nmethod::is_native_method()
• eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
• dd43bdd: 8319405: [s390] [jdk8] Increase javac default stack size for s390x zero
• ... and 21 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit 8cf7c96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.