8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #378

kurashige23 · 2023-09-28T09:39:50Z

Hi,

This is a backport of JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Original patch does not apply cleanly to JDK-8021961 applied code, because the fix uses "StringBuffer.isEmpty()" published in JDK15. I fixed the test so as not to use "StringBuffer.isEmpty()".

Testing: jdk_awt on RHEL7, GHA testing

Thanks.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8222323 needs maintainer approval

Issue

JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" (Bug - P4 - Approved)

Reviewers

Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/378/head:pull/378
$ git checkout pull/378

Update a local copy of the PR:
$ git checkout pull/378
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 378

View PR using the GUI difftool:
$ git pr show -t 378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/378.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-28T09:40:22Z

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into pr/377 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-09-28T09:40:44Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2023-09-28T09:45:47Z

Webrevs

01: Full - Incremental (ce74df4e)
00: Full (ce74df4e)

bridgekeeper · 2023-10-26T12:29:30Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2023-11-23T15:15:22Z

@kurashige23 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

kurashige23 · 2023-11-23T23:53:40Z

/open

openjdk · 2023-11-23T23:54:09Z

@kurashige23 This pull request is now open

jerboaa

Seems OK.

jerboaa · 2023-11-27T10:38:22Z

Please ask for approval of the bug using the /approval SKARA command so that the dependency and this one can get approved together.

kurashige23 · 2023-11-28T06:10:39Z

/approval JDK-8021961 request Test-only backport, no risk.

openjdk · 2023-11-28T06:11:01Z

@kurashige23 This issue is not associated with this pull request.

kurashige23 · 2023-11-28T06:23:50Z

/approval 377 request Test-only backport, no risk.

openjdk · 2023-11-28T06:24:23Z

@kurashige23 This issue is not associated with this pull request.

kurashige23 · 2023-11-28T06:34:07Z

/approval request Test-only backport, no risk.

openjdk · 2023-11-28T06:35:31Z

@kurashige23
8222323: The approval request has been created successfully.

phohensee · 2023-11-28T19:13:28Z

This PR has been approved, please add /integrate.

jerboaa · 2023-11-28T19:16:18Z

This PR has been approved, please add /integrate.

This needs #377 first.

openjdk-notifier · 2023-11-29T13:58:00Z

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout AlwaysOnTop_8222323
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2023-11-29T14:00:34Z

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk · 2023-11-29T14:00:38Z

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

8cf7c96: 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios
a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
2f81fb4: 8251551: Use .md filename extension for README
b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
3b9c787: 8208655: use JTreg skipped status in hotspot tests
0464401: 8320713: Bump update version of OpenJDK: 8u412
b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
10a653e: 8176509: Use pandoc for converting build readme to html
0e7ebcb: 8317291: Missing null check for nmethod::is_native_method()
eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
... and 22 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

phohensee · 2023-11-29T14:54:40Z

/sponsor

openjdk · 2023-11-29T14:55:19Z

@phohensee The change author (@kurashige23) must issue an integrate command before the integration can be sponsored.

kurashige23 · 2023-11-29T15:07:26Z

/integrate

openjdk · 2023-11-29T15:08:21Z

@kurashige23
Your change (at version ce74df4) is now ready to be sponsored by a Committer.

phohensee · 2023-11-29T15:09:19Z

/sponsor

openjdk · 2023-11-29T15:12:14Z

Going to push as commit b05e679.
Since your change was applied there have been 32 commits pushed to the master branch:

8cf7c96: 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios
a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
2f81fb4: 8251551: Use .md filename extension for README
b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
3b9c787: 8208655: use JTreg skipped status in hotspot tests
0464401: 8320713: Bump update version of OpenJDK: 8u412
b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
10a653e: 8176509: Use pandoc for converting build readme to html
0e7ebcb: 8317291: Missing null check for nmethod::is_native_method()
eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
... and 22 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-11-29T15:12:36Z

@phohensee @kurashige23 Pushed as commit b05e679.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

kurashige23 added 2 commits September 26, 2023 19:51

Backport 09a7c4bc4624dd39ab5500c394c1e298a43a711a

165bb7c

Backport 837928ba7955dbfd4a9c966209c3469c0fb5e195

ce74df4

openjdk bot changed the title ~~Backport 837928ba7955dbfd4a9c966209c3469c0fb5e195~~ 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" Sep 28, 2023

openjdk bot added backport rfr Pull request is ready for review labels Sep 28, 2023

bridgekeeper bot closed this Nov 23, 2023

openjdk bot reopened this Nov 23, 2023

jerboaa approved these changes Nov 24, 2023

View reviewed changes

openjdk bot added approval and removed approval labels Nov 28, 2023

openjdk-notifier bot changed the base branch from pr/377 to master November 29, 2023 13:57

openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 29, 2023

openjdk bot added the integrated Pull request has been integrated label Nov 29, 2023

openjdk bot closed this Nov 29, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 29, 2023

8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #378

8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #378

Uh oh!

Conversation

kurashige23 commented Sep 28, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 28, 2023

Uh oh!

openjdk bot commented Sep 28, 2023

Uh oh!

mlbridge bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

bridgekeeper bot commented Oct 26, 2023

Uh oh!

bridgekeeper bot commented Nov 23, 2023

Uh oh!

kurashige23 commented Nov 23, 2023

Uh oh!

openjdk bot commented Nov 23, 2023

Uh oh!

jerboaa left a comment

Choose a reason for hiding this comment

Uh oh!

jerboaa commented Nov 27, 2023

Uh oh!

kurashige23 commented Nov 28, 2023

Uh oh!

openjdk bot commented Nov 28, 2023

Uh oh!

kurashige23 commented Nov 28, 2023

Uh oh!

openjdk bot commented Nov 28, 2023

Uh oh!

kurashige23 commented Nov 28, 2023

Uh oh!

openjdk bot commented Nov 28, 2023

Uh oh!

phohensee commented Nov 28, 2023

Uh oh!

jerboaa commented Nov 28, 2023

Uh oh!

openjdk-notifier bot commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

phohensee commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

kurashige23 commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

phohensee commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

Uh oh!

kurashige23 commented Sep 28, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 28, 2023 •

edited

Loading