8317291: Missing null check for nmethod::is_native_method()

[tkiriyama]

I added null check to nmethod::is_native_method() and is_java_method().
I verified that the JVM crash problem no longer occurs by this fix.
I don't attach the test for this fix beause I could reproduce this problem only with debug build.

Would anyone review this fix, pelase?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317291 needs maintainer approval

Issue

• JDK-8317291: Missing null check for nmethod::is_native_method() (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/379/head:pull/379
$ git checkout pull/379

Update a local copy of the PR:
$ git checkout pull/379
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 379

View PR using the GUI difftool:
$ git pr show -t 379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/379.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (e8fd8dd5)

[bridgekeeper]

@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[tkiriyama]

Could someone please review this fix?

[openjdk]

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

@tkiriyama, please enable presubmit testing on you repo. You can do so by enabling it, then merging with the latest jdk8u-dev and pushing the result to your repo to invoke it.

[phohensee]

The original commit containing this two-line change is at https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/69d081845165 and very large. Which imo justifies a separate PR for 8.

[tkiriyama]

@phohensee
Thanks! I enabled it and all tests passed.

[phohensee]

Excellent. You can ask for maintainer approval now.

[gnu-andrew]

Looks like a sensible cherry-pick from that big changeset to me.
Approved for 8u.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8317291: The approval request has been approved.

[openjdk]

⚠️ @tkiriyama the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8317291
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317291: Missing null check for nmethod::is_native_method()

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
• dd43bdd: 8319405: [s390] [jdk8] Increase javac default stack size for s390x zero
• 8de4819: Merge
• 9499e54: 8317040: Exclude cleaner test failing on older releases
• 47a816e: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• dee2d2d: 8286503: Enhance security classes
• 33f3f1c: 8284910: Buffer clean in PasswordCallback
• 32ec85f: 8309966: Enhanced TLS connections
• 9b6da14: 8305815: Update Libpng to 1.6.39
• 6930f19: 8303384: Improved communication in CORBA
• ... and 13 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version e8fd8dd) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 0e7ebcb.
Since your change was applied there have been 23 commits pushed to the master branch:

• eace2d7: 8305329: [8u] Unify test libraries into single test library - step 1
• dd43bdd: 8319405: [s390] [jdk8] Increase javac default stack size for s390x zero
• 8de4819: Merge
• 9499e54: 8317040: Exclude cleaner test failing on older releases
• 47a816e: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• dee2d2d: 8286503: Enhance security classes
• 33f3f1c: 8284910: Buffer clean in PasswordCallback
• 32ec85f: 8309966: Enhanced TLS connections
• 9b6da14: 8305815: Update Libpng to 1.6.39
• 6930f19: 8303384: Improved communication in CORBA
• ... and 13 more: https://git.openjdk.org/jdk8u-dev/compare/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @tkiriyama Pushed as commit 0e7ebcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.