Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242330: Arrays should be cloned in several JAAS Callback classes #380

Closed
wants to merge 2 commits into from

Conversation

yan-too
Copy link
Contributor

@yan-too yan-too commented Sep 29, 2023

For 8u this backport does require a minimal update of the test preamble, some copyright date changes and paragraph symbols in comments.
CSR copy is filed as JDK-8317297.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8242330 needs maintainer approval

Issue

  • JDK-8242330: Arrays should be cloned in several JAAS Callback classes (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/380/head:pull/380
$ git checkout pull/380

Update a local copy of the PR:
$ git checkout pull/380
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 380

View PR using the GUI difftool:
$ git pr show -t 380

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/380.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2023

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8cd9241448f818b5e307d408ac4395b518791096 8242330: Arrays should be cloned in several JAAS Callback classes Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 29, 2023
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me. Paragraph tags are due to 8u lacking JDK-8028266

Are we not able to link the CSR to two bugs?

@openjdk
Copy link

openjdk bot commented Sep 29, 2023

⚠️ @yan-too This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member

/csr needed

@gnu-andrew
Copy link
Member

HotSpot test fail seems unrelated.

@gnu-andrew
Copy link
Member

Are we not able to link the CSR to two bugs?

I've linked it to an 8u backport bug now

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

@gnu-andrew has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@yan-too please create a CSR request for issue JDK-8242330 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

mlbridge bot commented Sep 29, 2023

Webrevs

@yan-too
Copy link
Contributor Author

yan-too commented Oct 5, 2023

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too determined that a CSR request is not needed for this pull request.

@openjdk openjdk bot added the approval label Oct 5, 2023
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version without documentation changes looks good.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@gnu-andrew
8242330: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242330: Arrays should be cloned in several JAAS Callback classes

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 27058b2: 8307837: [8u] Check step in GHA should also print errors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 5, 2023
@yan-too
Copy link
Contributor Author

yan-too commented Oct 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 27608e1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 27058b2: 8307837: [8u] Check step in GHA should also print errors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 5, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@yan-too Pushed as commit 27608e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants