8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null

[alexeybakhtin]

This is a follow-up fix for the JDK-8285398: Cache the results of constraint checks
Simple fix to prevent JCK failure

This fix should be applied after JDK-8285398

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8285696 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null (Bug - P2 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to f826982e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/382/head:pull/382
$ git checkout pull/382

Update a local copy of the PR:
$ git checkout pull/382
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 382

View PR using the GUI difftool:
$ git pr show -t 382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/382.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full (3cf6be47)
• 01: Full - Incremental (f826982e)
• 00: Full (51204bb5)

[jerboaa]

@alexeybakhtin Please mark this as a backport. PR title of Backport 47951655acacba515c0d69f5192257664f887dba should do it.

[openjdk]

@alexeybakhtin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[alexeybakhtin]

@alexeybakhtin Please mark this as a backport. PR title of Backport 47951655acacba515c0d69f5192257664f887dba should do it.

Sorry, forgot about the commit message. Fixed

[jerboaa]

LGTM.

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg'  is null

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit c851317.

[openjdk]

@alexeybakhtin Pushed as commit c851317.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.