JDK-8319405: [s390] [jdk8] Increase javac default stack size for s390x zero

[tstuefe]

This is a JDK8 - only patch to fix failing TCK tests for javac on s390.

s390x, by default, needs a lot of stack space for C++ frames since the s390x ABI requires a 160-byte register save area per frame. That affects JDK 8 in particular since we run Zero, and the C++ interpreter builds up C-frames for Java frames; furthermore, it affects javac since it recurses a lot.

This causes several javac TCK tests to fail with SOE (stmt33002mxxx).

To pass TCK, the default stack size of javac should be increased for s390 on JDK 8.

Testing:

• manually tested on s390 to see if the issue was resolved, which it was.
• manually tested on x64 to check that nothing changed
• GHAs

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8319405 needs maintainer approval

Issue

• JDK-8319405: [s390] [jdk8] Increase javac default stack size for s390x zero (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/385/head:pull/385
$ git checkout pull/385

Update a local copy of the PR:
$ git checkout pull/385
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 385

View PR using the GUI difftool:
$ git pr show -t 385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/385.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (b1c697b9)

[openjdk]

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

Looks good.

[jerboaa]

/approve

[openjdk]

@jerboaa usage: /approve [<id>] (yes|no)

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8319405: The approval request has been approved.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8319405: [s390] [jdk8] Increase javac default stack size for s390x zero

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 8de4819: Merge
• 9499e54: 8317040: Exclude cleaner test failing on older releases
• 47a816e: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• dee2d2d: 8286503: Enhance security classes
• 33f3f1c: 8284910: Buffer clean in PasswordCallback
• 32ec85f: 8309966: Enhanced TLS connections
• 9b6da14: 8305815: Update Libpng to 1.6.39
• 6930f19: 8303384: Improved communication in CORBA
• dc7013e: 8297856: Improve handling of Bidi characters
• 9d59e5b: 8295685: Update Libpng to 1.6.38
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/1e9eb5305384b74704023ca4f30919e3a77188ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Thanks @jerboaa !

/integrate

[openjdk]

Going to push as commit dd43bdd.
Since your change was applied there have been 14 commits pushed to the master branch:

• 8de4819: Merge
• 9499e54: 8317040: Exclude cleaner test failing on older releases
• 47a816e: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• dee2d2d: 8286503: Enhance security classes
• 33f3f1c: 8284910: Buffer clean in PasswordCallback
• 32ec85f: 8309966: Enhanced TLS connections
• 9b6da14: 8305815: Update Libpng to 1.6.39
• 6930f19: 8303384: Improved communication in CORBA
• dc7013e: 8297856: Improve handling of Bidi characters
• 9d59e5b: 8295685: Update Libpng to 1.6.38
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/1e9eb5305384b74704023ca4f30919e3a77188ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit dd43bdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.