Skip to content

Conversation

@yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Nov 10, 2023

I backport this for parity with 8u271.
Low risk, only test changes. Apply clean except for test path and Problemlist.txt. And test have been locally verified to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8198321 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/386/head:pull/386
$ git checkout pull/386

Update a local copy of the PR:
$ git checkout pull/386
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 386

View PR using the GUI difftool:
$ git pr show -t 386

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/386.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@yaqsun yaqsun changed the title javax/swing/JEditorPane/5076514/bug5076514.java fails Backport cc3756b342a367d3d29a31a18bdcc2fa4797bdcf Nov 10, 2023
@openjdk openjdk bot changed the title Backport cc3756b342a367d3d29a31a18bdcc2fa4797bdcf 8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 10, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2023

Webrevs

@yaqsun
Copy link
Contributor Author

yaqsun commented Nov 30, 2023

Hi all,
Please review my pr.
Thank you.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2023

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yaqsun
Copy link
Contributor Author

yaqsun commented Jan 3, 2024

Please review my pr.
Thank you very much.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@yaqsun
Copy link
Contributor Author

yaqsun commented Jan 9, 2024

/approval 8198321 request

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@yaqsun
8198321: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 9, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yaqsun
Copy link
Contributor Author

yaqsun commented Feb 18, 2024

Please maintainer approval my pr.
Thank you very much.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport is clean bar absence of the ProblemList.txt changes from JDK-8198333

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@gnu-andrew
8198321: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@yaqsun This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails

Reviewed-by: serb, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
  • f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  • b7bda28: 8325150: (tz) Update Timezone Data to 2024a
  • ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  • 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  • ... and 45 more: https://git.openjdk.org/jdk8u-dev/compare/eace2d732133accd3be9e95a9e75aee0fc1938f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 23, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Feb 26, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@yaqsun
Your change (at version 4153356) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

8u422 now open for commits
/sponsor

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 0bf84a2.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
  • f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  • b7bda28: 8325150: (tz) Update Timezone Data to 2024a
  • ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  • 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  • ... and 45 more: https://git.openjdk.org/jdk8u-dev/compare/eace2d732133accd3be9e95a9e75aee0fc1938f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@gnu-andrew @yaqsun Pushed as commit 0bf84a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants