8297955: LDAP CertStore should use LdapName and not String for DNs

[gnu-andrew]

JDK-8308592: "Framework for CA interoperability testing" merges the Actalis test into a single test which handles multiple CAs. Before we can backport that, we thus need to fix the Actalis test by backporting JDK-8297955 which also fixes 8224768

The backport is mostly clean. The code changes apply cleanly once applied to LDAPCertStore.java rather than LDAPCertStoreImpl.java which doesn't exist in 8u (a refactoring in JDK-8038084: "CertStore needs a way to add new CertStore types"). The unused getName() method needed to be removed as name is no longer a String. The ProblemList.txt change had to be manually added as did the copyright header change to LDAPCertStore.java.

The Actalis test passes after this backport. All other CA results match those on an unpatched build (GoogleCA currently seems to be broken on all 8u builds I had to hand)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8297955 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8224768 needs maintainer approval

Issues

• JDK-8297955: LDAP CertStore should use LdapName and not String for DNs (Bug - P4 - Approved)
• JDK-8224768: Test ActalisCA.java fails (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to 9fea5694

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/388/head:pull/388
$ git checkout pull/388

Update a local copy of the PR:
$ git checkout pull/388
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 388

View PR using the GUI difftool:
$ git pr show -t 388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/388.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/387 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 02: Full (22fd4a08)
• 01: Full - Incremental (9fea5694)
• 00: Full (9fea5694)

[gnu-andrew]

HotSpot failure looks like a sporadic GC test failure and unrelated to a JDK code change.

[jerboaa]

This looks OK. getName() got removed in later JDKs, by JDK-8224729. This patch is fine, though. No need to drag in that additional dependency.

[gnu-andrew]

This looks OK. getName() got removed in later JDKs, by JDK-8224729. This patch is fine, though. No need to drag in that additional dependency.

Thanks. I'd assumed it was part of the big refactoring in JDK-8038084 - and it's definitely a no for that one - but it seems it survived a bit longer and 8224729 was also backported for the 11 backport of this. I agree just removing getName is enough and we don't need to add more dependencies with that change.

[gnu-andrew]

/approval request Pre-requisite for JDK-8308592: "Framework for CA interoperability testing" so that the Actalis test is working before we switch to the new test structure where it is part of CAInterop.java

[openjdk]

@gnu-andrew
8297955: The approval request has been created successfully.
8224768: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8297955: The approval request has been approved.
8224768: The approval request has been approved.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8297955
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297955: LDAP CertStore should use LdapName and not String for DNs
8224768: Test ActalisCA.java fails

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

/integrate

[openjdk]

@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

Going to push as commit b2655a7.

[openjdk]

@gnu-andrew Pushed as commit b2655a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.