8312126: NullPointerException in CertStore.getCRLs after 8297955

[gnu-andrew]

Hi all,

This pull request contains a backport of commit 3c743cfe from the openjdk/jdk repository.

The commit being backported was authored by Sean Mullan on 15 Sep 2023 and was reviewed by Weijun Wang. It was backported to 17u on 2023-11-10 and a PR is open for 11u.

It is a simple fix and clean backport for a regression introduced by JDK-8297955 which was backported in PR 388. The new code in JDK-8297955 failed to catch a null IssuerName, allowing a NullPointerException to be thrown instead of the specified CertStoreException.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8312126 needs maintainer approval

Issue

• JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to 69299277

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/389/head:pull/389
$ git checkout pull/389

Update a local copy of the PR:
$ git checkout pull/389
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 389

View PR using the GUI difftool:
$ git pr show -t 389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/389.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/388 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (5d885d57)
• 01: Full - Incremental (69299277)
• 00: Full (69299277)

[jerboaa]

GHA test failure on 32 bit Linux seems unrelated: gc/6581734/Test6581734.java (timeout).

[jerboaa]

OK.

[gnu-andrew]

/approval request This is a simple fix and clean backport for a regression introduced by JDK-8297955, which was backported in #388 . The revised code in 8297955 now throws a NullPointerException where it should throw a CertStoreException.

[openjdk]

@gnu-andrew
8312126: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8312126: The approval request has been approved.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8312126
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312126: NullPointerException in CertStore.getCRLs after 8297955

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

/integrate

[openjdk]

@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

Going to push as commit a226a47.

[openjdk]

@gnu-andrew Pushed as commit a226a47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.