Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 #393

Closed
wants to merge 3 commits into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Nov 26, 2023

Follow-on bug fix for JDK-8304074 backport. Unclean backport from 11u, see openjdk/jdk11u-dev#2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8313081 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #392 must be integrated first

Issue

  • JDK-8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/393/head:pull/393
$ git checkout pull/393

Update a local copy of the PR:
$ git checkout pull/393
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 393

View PR using the GUI difftool:
$ git pr show -t 393

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/393.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2023

👋 Welcome back phh! A progress list of the required criteria for merging this PR into pr/392 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 Nov 26, 2023
@openjdk
Copy link

openjdk bot commented Nov 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 26, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2023

Webrevs

Copy link
Member

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial fix. Looks good.

@phohensee
Copy link
Member Author

/approval request Almost clean backport of a follow-on fix for the JDK-8304074 backport at #392. In production at Amazon for over two months.

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@phohensee
8313081: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 6, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

@phohensee This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Feb 1, 2024
@phohensee
Copy link
Member Author

/open

1 similar comment
@phohensee
Copy link
Member Author

/open

@zhaosongzs
Copy link
Member

Hi @phohensee, since the target branch pr/392 has been deleted(https://github.com/openjdk/jdk8u-dev/tree/pr/392), please update the target branch of your pr, then your command /open will be processed by skara bot.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@phohensee The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@phohensee The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 22, 2024

@phohensee Please target this PR onto master instead of pr/392 currently (or create a new one if you want). This PR is closed and is in the approval queue, which is strange. Ensure it's open, please.

@phohensee
Copy link
Member Author

I've filed a replacement PR at #475.

@phohensee
Copy link
Member Author

Submitted approval request for #475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
4 participants