-
Notifications
You must be signed in to change notification settings - Fork 173
8251551: Use .md filename extension for README #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean backport from 11u. GHA test failure appears unrelated (this PR doesn't affect GC).
|
|
|
/approval request Use .md filename extension for README, only updates README |
|
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
thanks |
|
Going to push as commit 2f81fb4.
Your commit was automatically rebased without conflicts. |
This backport adds
.mdextension to README. It also changes formulations a bit and adds some hyperlinks. Backport is not clean because there were small intermediate changes to README by (changesets not applicable to JDK8):(Git however considers this rewrite anyway.)
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/394/head:pull/394$ git checkout pull/394Update a local copy of the PR:
$ git checkout pull/394$ git pull https://git.openjdk.org/jdk8u-dev.git pull/394/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 394View PR using the GUI difftool:
$ git pr show -t 394Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/394.diff
Webrev
Link to Webrev Comment