Skip to content

Conversation

@zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 27, 2023

This backport adds .md extension to README. It also changes formulations a bit and adds some hyperlinks. Backport is not clean because there were small intermediate changes to README by (changesets not applicable to JDK8):

(Git however considers this rewrite anyway.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8251551 needs maintainer approval

Issue

  • JDK-8251551: Use .md filename extension for README (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/394/head:pull/394
$ git checkout pull/394

Update a local copy of the PR:
$ git checkout pull/394
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 394

View PR using the GUI difftool:
$ git pr show -t 394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/394.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4fbe635b21e3aba14dba760168a2f8965c7b29f5 8251551: Use .md filename extension for README Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean backport from 11u. GHA test failure appears unrelated (this PR doesn't affect GC).

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Use .md filename extension for README, only updates README

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@zzambers
8251551: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251551: Use .md filename extension for README

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
  • 3b9c787: 8208655: use JTreg skipped status in hotspot tests
  • 0464401: 8320713: Bump update version of OpenJDK: 8u412
  • b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 28, 2023
@zzambers
Copy link
Contributor Author

thanks
/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 2f81fb4.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
  • 3b9c787: 8208655: use JTreg skipped status in hotspot tests
  • 0464401: 8320713: Bump update version of OpenJDK: 8u412
  • b372b4b: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@zzambers Pushed as commit 2f81fb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants