Skip to content

Conversation

@ktakakuri
Copy link
Member

@ktakakuri ktakakuri commented Nov 28, 2023

Hi all,

This is a backport of JDK-8059847: complement JDK-8055286 and JDK-8056964 changes

JDK-8055286 and JDK-8056964 are already backported to JDK8, but this patch is not. For this reason, CompileCommand=option does not support flags of type double, as reported. So this patch should be applied.

The original patch is applied cleanly.

Testing: hotspot_tier1 including the test which come with this patch.

Thank you.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8059847 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8059847: complement JDK-8055286 and JDK-8056964 changes (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/396/head:pull/396
$ git checkout pull/396

Update a local copy of the PR:
$ git checkout pull/396
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 396

View PR using the GUI difftool:
$ git pr show -t 396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/396.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e210688db98357ab66718958d75b9970d4750fd2 8059847: complement JDK-8055286 and JDK-8056964 changes Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Nov 28, 2023

Please explain why this backport is needed? It's a P5 enhancement and it's unclear why it's needed now in the current stage of the lifecycle of OpenJDK 8.

@ktakakuri
Copy link
Member Author

Thank you for your comment.
When submitting this PR, I thought that the -XX:CompileCommand=option could handle all available flag types except double and that this follow-up enhancement should be backported for completeness.
However the uint64_t type is used as a flag type but is not handled by CompileCommand.
Now that I know this, I don't think there's much need to backport this fix, so I close this request.

@ktakakuri ktakakuri closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants