8059847: complement JDK-8055286 and JDK-8056964 changes #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a backport of JDK-8059847: complement JDK-8055286 and JDK-8056964 changes
JDK-8055286 and JDK-8056964 are already backported to JDK8, but this patch is not. For this reason, CompileCommand=option does not support flags of type double, as reported. So this patch should be applied.
The original patch is applied cleanly.
Testing: hotspot_tier1 including the test which come with this patch.
Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/396/head:pull/396$ git checkout pull/396Update a local copy of the PR:
$ git checkout pull/396$ git pull https://git.openjdk.org/jdk8u-dev.git pull/396/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 396View PR using the GUI difftool:
$ git pr show -t 396Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/396.diff
Webrev
Link to Webrev Comment