-
Notifications
You must be signed in to change notification settings - Fork 171
8317373: Add Telia Root CA v2 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The windows x64 build failure looks suspicous. It doesn't fail in #390 which this PR is based on and doesn't really change anything related to the build failure. |
|
windows-x64 failure appears to be an infrastructure issue. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk-8317373-telia-root2
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
|
|
@jerboaa this pull request can not be integrated into git checkout jdk-8317373-telia-root2
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
243ad71 to
c4e404e
Compare
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
With the latest merge #368 is part of it, so GHA should run the tests as well. |
|
Test failures seem infra related. All pass in #398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed clean.
|
/approval yes |
|
@gnu-andrew Only the author (@jerboaa) is allowed to issue the |
|
Let's try again. |
|
@gnu-andrew |
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
Testing:
jdk/test/sun/security/lib/cacertsandjdk/test/security/infra/java/security/cert/CertPathValidatorjtreg tests (including the new one). All pass.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/397/head:pull/397$ git checkout pull/397Update a local copy of the PR:
$ git checkout pull/397$ git pull https://git.openjdk.org/jdk8u-dev.git pull/397/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 397View PR using the GUI difftool:
$ git pr show -t 397Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/397.diff
Webrev
Link to Webrev Comment