8186902: jcmd GC.run should not be blocked by DisableExplicitGC #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to backport this parity bug to openjdk8u.
Original bug: https://bugs.openjdk.java.net/browse/JDK-8186902
Original patch:
http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/3d1150c7899c
The original patch does not apply cleanly. Besides line shifts, 8u does
not define
GCCause::_dcmd_gc_run
, butGCCause::_java_lang_system_gc
instead.Original code review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-September/014288.html
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/40/head:pull/40
$ git checkout pull/40
Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/40/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 40
View PR using the GUI difftool:
$ git pr show -t 40
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/40.diff