8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese #400

ktakakuri · 2023-11-29T10:55:17Z

I would like to fix this issue because the test dose not work as intended.
Could someone please review it?

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8320964 needs maintainer approval

Issue

JDK-8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese (Bug - P4 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/400/head:pull/400
$ git checkout pull/400

Update a local copy of the PR:
$ git checkout pull/400
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 400

View PR using the GUI difftool:
$ git pr show -t 400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/400.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-11-29T10:56:17Z

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2023-11-29T10:59:25Z

Webrevs

phohensee · 2023-11-29T17:25:45Z

linux-x86 failure seems unrelated, but please have a look at the windows-x64 failure.

openjdk · 2023-11-29T17:26:49Z

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

gnu-andrew

The tool and its tests are removed in 11u and later by JDK-8074431 so this is only applicable to 8u. The incorrect \\r was still in place when removed.

Is this specific to Japanese? It seems like it would fail with any Windows output containing carriage returns. Is it just that the Japanese character set needs conversion from native to ASCII?

The fix itself looks good. The copyright year needs to be bumped and the bug ID added to the @bug line. It will probably need to be split onto a new line due to the length; see jdk/test/java/util/Locale/LocaleTest.java for an example of this.

bridgekeeper · 2024-01-04T04:17:13Z

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-02-01T06:07:45Z

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

ktakakuri · 2024-02-27T08:03:37Z

/open

openjdk · 2024-02-27T08:04:49Z

@ktakakuri This pull request is now open

openjdk · 2024-03-13T20:06:08Z

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

fc15e99: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
ddce2b5: 8299677: Formatter.format might take a long time to format an integer or floating-point
c8eb027: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
16ea85b: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
54f7734: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
385e34d: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
44eac48: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
a0715ab: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
b499ea7: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
b1e2ea8: 8279164: Disable TLS_ECDH_* cipher suites
... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/1db6a7606c297fd87d5f143cac40e7652b94404c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

ktakakuri · 2024-04-10T12:39:20Z

I run the test on English Windows and also found to occur on the following environment:

$ systeminfo
OS Name:                   Microsoft Windows Server 2016 Standard
System Locale:             en-us;English (United States)

$ sed --version
sed (GNU sed) 4.8
Packaged by Cygwin (4.8-1)
Copyright (C) 2020 Free Software Foundation, Inc.

I fixed copyright and added the bug ID.

bridgekeeper · 2024-05-08T17:43:02Z

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

ktakakuri · 2024-05-14T10:33:03Z

@gnu-andrew
Could you please check for added fixes?

gnu-andrew

Could you indent the new bug ID as in VerifyCACerts.java (i.e. so the '8' in the new ID lines up with the '4' in the one above)? Sorry for providing you with a bad example at first in LocaleTest.java

With that change, this should be good to go.

ktakakuri · 2024-05-23T06:27:42Z

I fixed the indent. Thank you.

bridgekeeper · 2024-06-20T07:52:52Z

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

ktakakuri · 2024-06-20T08:41:29Z

@gnu-andrew
Is the fix correct?

gnu-andrew

Yes, looks good.

gnu-andrew · 2024-07-15T21:56:49Z

Sorry for the delay, I've been caught up with the upcoming release.
Please apply for approval and we can get this in.

ktakakuri · 2024-07-16T06:02:24Z

Thank you for checking my fix.
I will submit a fix request.

ktakakuri · 2024-07-16T06:05:32Z

/approval request I would like to fix this issue because it always fails in regression testing, resulting in extra costs for checking the test results.
There is no risk.
Testing:
I tested it on Windows and Linux.

openjdk · 2024-07-16T06:06:13Z

@ktakakuri
8320964: The approval request has been created successfully.

gnu-andrew · 2024-07-16T20:07:41Z

/approve yes

openjdk · 2024-07-16T20:08:35Z

@gnu-andrew
8320964: The approval request has been approved.

ktakakuri · 2024-07-18T00:03:58Z

/integrate

openjdk · 2024-07-18T00:05:00Z

@ktakakuri
Your change (at version 052174e) is now ready to be sponsored by a Committer.

gnu-andrew · 2024-07-18T17:29:32Z

/sponsor

openjdk · 2024-07-18T17:31:17Z

Going to push as commit 21e4278.
Since your change was applied there have been 41 commits pushed to the master branch:

fc15e99: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
ddce2b5: 8299677: Formatter.format might take a long time to format an integer or floating-point
c8eb027: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
16ea85b: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
54f7734: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
385e34d: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
44eac48: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
a0715ab: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
b499ea7: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
b1e2ea8: 8279164: Disable TLS_ECDH_* cipher suites
... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/1db6a7606c297fd87d5f143cac40e7652b94404c...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-07-18T17:31:26Z

@gnu-andrew @ktakakuri Pushed as commit 21e4278.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix Native2AsciiTests.sh

d29d1e5

openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023

phohensee approved these changes Nov 29, 2023

View reviewed changes

gnu-andrew reviewed Dec 7, 2023

View reviewed changes

bridgekeeper bot closed this Feb 1, 2024

openjdk bot reopened this Feb 27, 2024

ktakakuri added 2 commits April 8, 2024 21:03

Fix copyright year and @bug

89eec90

Merge branch 'master' into 8320964

bb315b1

gnu-andrew suggested changes May 22, 2024

View reviewed changes

#Fix the indent

052174e

phohensee approved these changes Jul 10, 2024

View reviewed changes

gnu-andrew approved these changes Jul 15, 2024

View reviewed changes

openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 16, 2024

openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 16, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2024

openjdk bot added the integrated Pull request has been integrated label Jul 18, 2024

openjdk bot closed this Jul 18, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2024

8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese #400

8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese #400

Uh oh!

Conversation

ktakakuri commented Nov 29, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Nov 29, 2023

Uh oh!

mlbridge bot commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

phohensee commented Nov 29, 2023

Uh oh!

openjdk bot commented Nov 29, 2023

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

bridgekeeper bot commented Jan 4, 2024

Uh oh!

bridgekeeper bot commented Feb 1, 2024

Uh oh!

ktakakuri commented Feb 27, 2024

Uh oh!

openjdk bot commented Feb 27, 2024

Uh oh!

openjdk bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktakakuri commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bridgekeeper bot commented May 8, 2024

Uh oh!

ktakakuri commented May 14, 2024

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

ktakakuri commented May 23, 2024

Uh oh!

bridgekeeper bot commented Jun 20, 2024

Uh oh!

ktakakuri commented Jun 20, 2024

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

gnu-andrew commented Jul 15, 2024

Uh oh!

ktakakuri commented Jul 16, 2024

Uh oh!

ktakakuri commented Jul 16, 2024

Uh oh!

openjdk bot commented Jul 16, 2024

Uh oh!

gnu-andrew commented Jul 16, 2024

Uh oh!

openjdk bot commented Jul 16, 2024

Uh oh!

ktakakuri commented Jul 18, 2024

Uh oh!

openjdk bot commented Jul 18, 2024

Uh oh!

gnu-andrew commented Jul 18, 2024

Uh oh!

openjdk bot commented Jul 18, 2024

Uh oh!

openjdk bot commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

ktakakuri commented Nov 29, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 29, 2023 •

edited

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading

ktakakuri commented Apr 10, 2024 •

edited

Loading