8319187: Add three eMudhra emSign roots

[jerboaa]

Clean backport of the JDK 11u patch of
some more cacert additions (modulo path adjustments). Please review!

Testing:

• GHA (still running). Includes cacerts testing these days.
• cacerts tests locally on Linux x86_64. All pass (including the new tests).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8319187 needs maintainer approval

Issue

• JDK-8319187: Add three eMudhra emSign roots (Enhancement - P2 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/401/head:pull/401
$ git checkout pull/401

Update a local copy of the PR:
$ git checkout pull/401
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 401

View PR using the GUI difftool:
$ git pr show -t 401

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/401.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/399 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (d9570013)
• 01: Full - Incremental (57bc091c)
• 00: Full (57bc091c)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8319187-add-emudhra-certs
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[gnu-andrew]

I see some contextual differences:

-@@ -586,6 +606,13 @@ public class CAInterop {
-                     return new CATestURLs("https://validpremiumecc.affirmtrust.com",
-                             "https://revokedpremiumecc.affirmtrust.com");
+@@ -532,6 +552,13 @@ private CATestURLs getTestURLs(String alias) {
+                     return new CATestURLs("https://juolukka.cover.telia.fi:10600",
+                             "https://juolukka.cover.telia.fi:10601");

It seems JDK-8268916 should go in first and make this a cleaner backport.

[jerboaa]

OK, I'll work on a backport of JDK-8268916, but it doesn't need to go in the same order as JDK 11. It's just context difference. How about we get this one in first and I'll follow up with the test addition in parallel? Seems counter-intuitive to require JDK-8268916 first. It's a test change only and unrelated to this patch.

[gnu-andrew]

Alright, I'm ok with that as long as the files are the same once both patches are applied.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

Thanks. Asked for approval.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8319187: The approval request has been approved.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8319187: Add three eMudhra emSign roots

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 31162fb.

[openjdk]

@jerboaa Pushed as commit 31162fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.