8293562: KeepAliveCache Blocks Threads while Closing Connections

[dhanalla]

Issue: JDK-8293562: KeepAliveCache Blocks Threads while Closing Connections
Backport of PR openjdk/jdk11u-dev#1890 fromJDK11 to JDK8.

The JDK11 patch doesn't apply cleanly due to file path/structure changes and the transformation of the ClientVector class to ArrayDeque from a Stack, resulting in changes being picked individually.

Test performed:

1. JTreg jdk_tier1
2. JTreg jdk_tier2
3. New test case added to this PR passed with the fix and failed without it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8293562 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with updated jcheck configuration in pull request)

Issue

• JDK-8293562: KeepAliveCache Blocks Threads while Closing Connections (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/402/head:pull/402
$ git checkout pull/402

Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 402

View PR using the GUI difftool:
$ git pr show -t 402

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/402.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (b9a4f386)

[gnu-andrew]

It's difficult to review this accurately because it now contains both 8293562 and most of JDK-8155590 for the ArrayDeque change.

I'd be more comfortable with this if we backported 8155590 separately and then rebased this change on top of that. Although this looks correct when I apply it and compare it to the 11u version, we end up with minor differences remaining that may then cause issues for any later changes. With looking at each patch separately, it makes it possible to compare it with the 11u version of the patch and spot any differences.

I had a quick look at 8155590 myself and it largely applies, with just a few hunks needing to be done manually (which I suspect you already had to do for this patch).

[dhanalla]

It's difficult to review this accurately because it now contains both 8293562 and most of JDK-8155590 for the ArrayDeque change.

I'd be more comfortable with this if we backported 8155590 separately and then rebased this change on top of that. Although this looks correct when I apply it and compare it to the 11u version, we end up with minor differences remaining that may then cause issues for any later changes. With looking at each patch separately, it makes it possible to compare it with the 11u version of the patch and spot any differences.

I had a quick look at 8155590 myself and it largely applies, with just a few hunks needing to be done manually (which I suspect you already had to do for this patch).

Thanks @gnu-andrew for the code review.
As you suggested, I have created two separate PRs for each backport.
#407
#409

[bridgekeeper]

@dhanalla This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@dhanalla this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout Backport-KeepAliveCache
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[dhanalla]

The changes in this old PR are now part of multiple PRs under review.