8302017: Allocate BadPaddingException only if it will be thrown

[alexeybakhtin]

Almost clean backport from JDK11 PR
The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8302017 needs maintainer approval

Issue

• JDK-8302017: Allocate BadPaddingException only if it will be thrown (Enhancement - P3 - Approved)

Reviewers

• Martin Balao (@martinuy - Reviewer) ⚠️ Review applies to 2110d9f5
• Andrew John Hughes (@gnu-andrew - Reviewer) ⚠️ Review applies to 2110d9f5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/403.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (8e33ae82)
• 01: Full - Incremental (2110d9f5)
• 00: Full (66deb0df)

[martinuy]

Hi @alexeybakhtin

Thanks for proposing this backport.

Two minor comments:

1. The copyright date change in RSAPadding.java is not necessary (I made this comment for 17u and 11u too).

2. Would you mind adding the comment "// https://www.rfc-editor.org..." (and the line before) inside the try block as in 17u and 11u?

Thanks,
Martin.-

[alexeybakhtin]

Hi @alexeybakhtin

Thanks for proposing this backport.

Two minor comments:

1. The copyright date change in RSAPadding.java is not necessary (I made this comment for 17u and 11u too).
2. Would you mind adding the comment "// https://www.rfc-editor.org..." (and the line before) inside the try block as in 17u and 11u?

Thanks, Martin.-

Thank you @martinuy !
Both comments are fixed now

[alexeybakhtin]

Pre-submit test failures are not related to the current changes

[martinuy]

Thanks for proposing this backport.

I meant adding the "// https://www.rfc..." comment only to the try block, not the previous "if". In 8u we don't have 8149802 that adds a try-finally block to call resetDigest, so there isn't a reason for it. Should cause no harm, but I'd keep it as in your 1st proposal. Sorry for the confusion. Anyways, this is a minor detail, looks good to me.

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8302017: Allocate BadPaddingException only if it will be thrown

Reviewed-by: mbalao, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

Patch is mostly clean, bar moving the try block in RSASignature.java. There's a compatibility risk there, but it seems reasonably safe. I don't think JDK-8149802 i suitable for backporting as it introduces a reset in a finally block.

[alexeybakhtin]

Thank you. I've moved length checking out of the try block

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit 2131e40.

[openjdk]

@alexeybakhtin Pushed as commit 2131e40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.