8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited #405
Conversation
|
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
| * @key headful | ||
| * @key randomness | ||
| * | ||
| * @modules java.desktop/sun.awt |
There was a problem hiding this comment.
@modules tag is not needed for jdk8
There was a problem hiding this comment.
But looks like nobody cares when backport such changes: https://github.com/search?q=repo%3Aopenjdk%2Fjdk8u-dev%20%40modules%20&type=code
So it is probably looks fine, @gnu-andrew what do you think?
|
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
keep open |
There was a problem hiding this comment.
Patch looks clean, bar the header and the indentation changes around robot.waitIdle(). I confirmed all but the header are the same as 11u once this patch is applied.
As to @modules, we can either drop it here or do it as part of a cleanup in bulk as for #441
|
|
|
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/approval request This fix applis cleanly to 8u from jdk9, |
|
@ktakakuri |
|
I guess we're removing |
|
@gnu-andrew |
openjdk
bot
added
ready
|
After requesting the fix request I made an additional commit, which is a fix for a syntax error. |
|
/integrate |
|
@ktakakuri |
|
/sponsor |
|
Going to push as commit 6a09637.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@phohensee @ktakakuri Pushed as commit 6a09637. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
I have confirmed that bug7123767.java passes by backporting this fix.
Thank you.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/405/head:pull/405$ git checkout pull/405Update a local copy of the PR:
$ git checkout pull/405$ git pull https://git.openjdk.org/jdk8u-dev.git pull/405/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 405View PR using the GUI difftool:
$ git pr show -t 405Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/405.diff
Webrev
Link to Webrev Comment