8268916: Tests for AffirmTrust roots

[jerboaa]

Clean backport modulo context differences (after path suffeling). After this, CAInterop.java is the same as in openjdk/jdk11u. Patch as requested in #401

Testing:

• GHA (includes new tests).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8268916 needs maintainer approval

Issue

• JDK-8268916: Tests for AffirmTrust roots (Enhancement - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/406/head:pull/406
$ git checkout pull/406

Update a local copy of the PR:
$ git checkout pull/406
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 406

View PR using the GUI difftool:
$ git pr show -t 406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/406.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (33e3f86c)
• 01: Full - Incremental (309219f0)
• 00: Full (974e0d42)

[phohensee]

linux-x86 GHA failure is unrelated.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

linux-x86 GHA failure is unrelated.

Yes, thanks. We see the 32-bit failure of gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java regularly. This patch doesn't change anything that could be related.

[bridgekeeper]

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

Keep open please.

[bridgekeeper]

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

Keep open.

[gnu-andrew]

Backport looks clean, other than the context difference from applying the eMudhra changes first.

[gnu-andrew]

Approval comment from bug: "Please approve this low-risk test addition for 8u. The patch applies cleanly but it has been re-ordered so as to match the final JDK 11u file (CAInterop.java). Test-only change low risk. Patch reviewed by Paul Hohensee."
/approve yes

[openjdk]

@gnu-andrew
8268916: The approval request has been approved.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268916: Tests for AffirmTrust roots

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Failing test gc/logging/TestGCId.java on 32 bit linux is unrelated.

/integrate

[openjdk]

Going to push as commit f63643b.

[openjdk]

@jerboaa Pushed as commit f63643b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.