8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

[dhanalla]

Issue: JDK-8155590 Dubious collection management in sun.net.www.http.KeepAliveCache

Backport 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8155590 needs maintainer approval

Issue

• JDK-8155590: Dubious collection management in sun.net.www.http.KeepAliveCache (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/407/head:pull/407
$ git checkout pull/407

Update a local copy of the PR:
$ git checkout pull/407
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 407

View PR using the GUI difftool:
$ git pr show -t 407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/407.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (0ef34e3b)

[jerboaa]

@dhanalla Please use Backport 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650 as the PR title so that the patch gets properly recognized as a backport.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[dhanalla]

@dhanalla Please use Backport 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650 as the PR title so that the patch gets properly recognized as a backport.

Done, Thanks @jerboaa for reviewing this PR.

[jerboaa]

This patch seems fine to me.

[openjdk]

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[dhanalla]

This patch seems fine to me.

Thanks @jerboaa for reviewing this PR.
Can you please review the main PR #409 that depends on this one.

[dhanalla]

/approval

[openjdk]

@dhanalla usage: /approval [<id>] (request|cancel) [<text>]

[dhanalla]

/approval request Backport of bug [JDK-8155590] Dubious collection management in sun.net.www.http.KeepAliveCache

[openjdk]

@dhanalla
8155590: The approval request has been created successfully.

[jerboaa]

/approval request Backport of bug [JDK-8155590] Dubious collection management in sun.net.www.http.KeepAliveCache

@dhanalla Fix request comments should be more than stating the obvious, please. See: https://openjdk.org/projects/jdk-updates/approval.html Mention the testing you've done and the risk you estimate for getting this integrated.

[dhanalla]

/approval request Backport of bug [JDK-8155590] Dubious collection management in sun.net.www.http.KeepAliveCache

@dhanalla Fix request comments should be more than stating the obvious, please. See: https://openjdk.org/projects/jdk-updates/approval.html Mention the testing you've done and the risk you estimate for getting this integrated.

Thanks @jerboaa , Updated the bug with a comment requesting the fix.

[openjdk]

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 15e2c0b: 8322725: (tz) Update Timezone Data to 2023d
• 474c8c1: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• 7c693ce: 8316976: Improve signature handling
• 199cb32: 8314468: Improve Compiler loops
• f7cb28d: 8314307: Improve loop handling
• 77d38b7: 8314295: Enhance verification of verifier
• 5e0e2bf: 8314284: Enhance Nashorn performance
• ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/7098ac7ba63ab08d96605caf25173848111fd0db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dhanalla]

/integrate

[openjdk]

@dhanalla
Your change (at version 0ef34e3) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit cfed45d.
Since your change was applied there have been 23 commits pushed to the master branch:

• 818c53e: 8315042: NPE in PKCS7.parseOldSignedData
• f4f45e3: 8321060: [8u] hotspot needs to recognise VS2022
• 15e2c0b: 8322725: (tz) Update Timezone Data to 2023d
• 474c8c1: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• 7c693ce: 8316976: Improve signature handling
• 199cb32: 8314468: Improve Compiler loops
• f7cb28d: 8314307: Improve loop handling
• ... and 13 more: https://git.openjdk.org/jdk8u-dev/compare/7098ac7ba63ab08d96605caf25173848111fd0db...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @dhanalla Pushed as commit cfed45d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.