Skip to content

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 18, 2023

Sync jdk8u402-b05


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/408/head:pull/408
$ git checkout pull/408

Update a local copy of the PR:
$ git checkout pull/408
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 408

View PR using the GUI difftool:
$ git pr show -t 408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/408.diff

jerboaa and others added 5 commits December 16, 2023 19:53
Reviewed-by: phh, andrew
Backport-of: d3ebb4a155be8ed93e79b6b58c645e861ec30267
Reviewed-by: phh, andrew
Backport-of: e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83
Reviewed-by: phh, andrew
Backport-of: 0ea58048f9b4cdaaa0470b2bcc03913fb3939453
Reviewed-by: andrew
Backport-of: 0bda467f6e29c866c661e88a76a9fe3efc0a0d19
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 18, 2023
@gnu-andrew
Copy link
Member Author

Failures unrelated to merge.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

Going to push as commit d898d40.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2023
@openjdk openjdk bot closed this Dec 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@gnu-andrew Pushed as commit d898d40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants