Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8129940: JRadioButton does not honor non-standard FocusTraversalKeys #41

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 19, 2022

I would like to backport this patch to openjdk8u for parity with Oracle
8u311.

The original bug: https://bugs.openjdk.java.net/browse/JDK-8129940
The original patch:
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fbf897c33625

The jdk9 patch does not apply cleanly, but only conflict is copyright
year of BasicRadioButtonUI.java file.

Test:

  • Included FocusTraversal/FocusTraversal.java test fails without patch and passes with it on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8129940: JRadioButton does not honor non-standard FocusTraversalKeys ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/41/head:pull/41
$ git checkout pull/41

Update a local copy of the PR:
$ git checkout pull/41
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/41/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 41

View PR using the GUI difftool:
$ git pr show -t 41

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/41.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@zhengyu123 zhengyu123 marked this pull request as ready for review Apr 19, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2022

@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2022

@zhengyu123 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant