-
Notifications
You must be signed in to change notification settings - Fork 171
8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/issue add 8251155 |
|
@phohensee Only the author (@yaqsun) is allowed to issue the |
|
/issue add 8251155 |
|
@yaqsun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Please check GHA failure, looks unrelated to me, but you may differ.
|
|
|
/approval 8251155 request |
|
/approval 8276139 request |
|
@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
/approve yes |
|
@jerboaa |
|
@yaqsun This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
Going to push as commit e926edc.
Your commit was automatically rebased without conflicts. |
|
@phohensee @yaqsun Pushed as commit e926edc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Why have two backports been bundled into one PR here? That doesn't seem to be the case in 11u and later. |
A reason should be given as to why the request should be approved. See https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval |
It is not reliable for a to modify this problem, so JDK-8276139 is submitted on the basis of JDK-8251155. JDK-8251155 and JDK-8276139 have been in 11u and later. |
It is not reliable for a to modify this problem, so JDK-8276139 is submitted on the basis of JDK-8251155. JDK-8251155 and JDK-8276139 have been in 11u and later. so I backport JDK-8251155 and JDK-8276139 into one PR here.
Apply clean except for test path. And test have been locally verified to pass.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/411/head:pull/411$ git checkout pull/411Update a local copy of the PR:
$ git checkout pull/411$ git pull https://git.openjdk.org/jdk8u-dev.git pull/411/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 411View PR using the GUI difftool:
$ git pr show -t 411Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/411.diff
Webrev
Link to Webrev Comment