Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321060: [8u] hotspot needs to recognise VS2022 #412

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 3, 2024

The hotspot build scripts are updated to recognize the latest versions of VS2022. The fix is similar to:
#187


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8321060 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8321060: [8u] hotspot needs to recognise VS2022 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/412/head:pull/412
$ git checkout pull/412

Update a local copy of the PR:
$ git checkout pull/412
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 412

View PR using the GUI difftool:
$ git pr show -t 412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/412.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review January 3, 2024 01:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 9, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Feb 6, 2024

keep open

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321060: [8u] hotspot needs to recognise VS2022

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 6, 2024
@mrserb
Copy link
Member Author

mrserb commented Feb 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

Going to push as commit f4f45e3.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 7, 2024
@openjdk openjdk bot closed this Feb 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 7, 2024
@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@mrserb Pushed as commit f4f45e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants