-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321060: [8u] hotspot needs to recognise VS2022 #412
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep open |
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit f4f45e3.
Your commit was automatically rebased without conflicts. |
The hotspot build scripts are updated to recognize the latest versions of VS2022. The fix is similar to:
#187
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/412/head:pull/412
$ git checkout pull/412
Update a local copy of the PR:
$ git checkout pull/412
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/412/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 412
View PR using the GUI difftool:
$ git pr show -t 412
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/412.diff
Webrev
Link to Webrev Comment