-
Notifications
You must be signed in to change notification settings - Fork 171
8322725: (tz) Update Timezone Data to 2023d #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
We probably want @gnu-andrew to look through it. |
|
@lutkerd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
|
/approval request Low risk and local tests passing. |
|
@lutkerd This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
Going to push as commit 15e2c0b.
Your commit was automatically rebased without conflicts. |
|
Any idea why this backport lost the change to |
Update to the latest tzdata 2023d.
Similar fix to 11/17, but not a clean backport as 8 uses different format.
Tested: jdk/test/java/util/TimeZone jdk/test/java/time/test jdk/test/sun/util/resources jdk/test/sun/text/resources jdk/test/sun/util/calendar and all are passing.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/414/head:pull/414$ git checkout pull/414Update a local copy of the PR:
$ git checkout pull/414$ git pull https://git.openjdk.org/jdk8u-dev.git pull/414/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 414View PR using the GUI difftool:
$ git pr show -t 414Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/414.diff
Webrev
Link to Webrev Comment