8315042: NPE in PKCS7.parseOldSignedData

[mrserb]

Hi all,

This pull request contains a backport of commit 8c0d026d from the openjdk/jdk repository.

The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8315042 needs maintainer approval

Issue

• JDK-8315042: NPE in PKCS7.parseOldSignedData (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/415/head:pull/415
$ git checkout pull/415

Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 415

View PR using the GUI difftool:
$ git pr show -t 415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/415.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (8f671c97)

[mrserb]

/clean The changes are in the context only

[openjdk]

@mrserb This backport pull request is now marked as clean

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315042: NPE in PKCS7.parseOldSignedData

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• 7c693ce: 8316976: Improve signature handling
• 199cb32: 8314468: Improve Compiler loops
• f7cb28d: 8314307: Improve loop handling
• 77d38b7: 8314295: Enhance verification of verifier
• 5e0e2bf: 8314284: Enhance Nashorn performance
• 7f5db81: 8308204: Enhanced certificate processing
• e7ede49: 8320597: RSA signature verification fails on signed data that does not encode params correctly
• ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/d898d4018e0a16f2115f4b1cbf93eb5e653b789b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 818c53e.
Since your change was applied there have been 14 commits pushed to the master branch:

• f4f45e3: 8321060: [8u] hotspot needs to recognise VS2022
• 15e2c0b: 8322725: (tz) Update Timezone Data to 2023d
• 474c8c1: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• 7c693ce: 8316976: Improve signature handling
• 199cb32: 8314468: Improve Compiler loops
• f7cb28d: 8314307: Improve loop handling
• 77d38b7: 8314295: Enhance verification of verifier
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/d898d4018e0a16f2115f4b1cbf93eb5e653b789b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 818c53e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.