8323202: [8u] Remove get_source.sh and hgforest.sh

[zzambers]

Remove get_source.sh and hgforest.sh scripts. These scripts were used with mercurial forest and are no longer useful after switching to git.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323202 needs maintainer approval

Issue

• JDK-8323202: [8u] Remove get_source.sh and hgforest.sh (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 56cba689
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/417/head:pull/417
$ git checkout pull/417

Update a local copy of the PR:
$ git checkout pull/417
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 417

View PR using the GUI difftool:
$ git pr show -t 417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/417.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (833f3a80)
• 00: Full (56cba689)

[openjdk]

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

You probably need to backport this one first https://hg.openjdk.org/jdk9/jdk9/rev/ea7a041eb994

[gnu-andrew]

You probably need to backport this one first https://hg.openjdk.org/jdk9/jdk9/rev/ea7a041eb994

Yes, I think we can use this bug ID and just include get_source.sh as well (removed by 8187443: "Forest Consolidation: Move files to unified layout" which we're obviously not going to backport). Certainly, webrev.ksh should be removed as part of this as well.

[gnu-andrew]

You probably need to backport this one first https://hg.openjdk.org/jdk9/jdk9/rev/ea7a041eb994

Yes, I think we can use this bug ID and just include get_source.sh as well (removed by 8187443: "Forest Consolidation: Move files to unified layout" which we're obviously not going to backport). Certainly, webrev.ksh should be removed as part of this as well, along with the duplicate hgforest.sh.

[zzambers]

@mrserb @gnu-andrew sorry, originally I just wanted to remove get_source.sh (part of forest consolidation), than found that other script, but missed, that it had a separate bug. :/ Should I close this PR and create new one or just modify this one and add issue using /issue?

[gnu-andrew]

@mrserb @gnu-andrew sorry, originally I just wanted to remove get_source.sh (part of forest consolidation), than found that other script, but missed, that it had a separate bug. :/ Should I close this PR and create new one or just modify this one and add issue using /issue?

I would do a separate PR for a backport of 8011180, and then come back to this one as get_source.sh and the other hgforest.sh will still need to be removed.

$ find -name 'hgforest.sh'
./common/bin/hgforest.sh
./make/scripts/hgforest.sh

The other bug only removes the one in make/scripts so this could remove the one in common/bin.

[zzambers]

Oh, one more hgforest.sh :)

I have created PR for JDK-8011180 backport.
After that one I'll update name and chegeset of this one to remove remaining files.

[openjdk]

@zzambers Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[zzambers]

I have updated this PR to do rest of cleanup after JDK-8011180. (Obsolete scripts removed in newer JDKs by JDK-8187443.)

I have realized, that I can keep issue/PR name as the only difference to original changeset happens to be, that it removes the other hgforest.sh. :)

[gnu-andrew]

Looks good to me. Thanks for doing the other backport.

[zzambers]

/approval request Remove leftover scripts (used with mercurial forest, no longer useful/working with git). In newer JDKs they were removed by JDK-8187443 (Forest Consolidation: Move files to unified layout).

[openjdk]

@zzambers
8323202: The approval request has been created successfully.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8323202: The approval request has been approved.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8323202: [8u] Remove get_source.sh and hgforest.sh

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zzambers]

/integrate

[openjdk]

Going to push as commit 3dc011b.

[openjdk]

@zzambers Pushed as commit 3dc011b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.