8168518: rcache interop with krb5-1.15

[alexeybakhtin]

I'd like to backport JDK-8168518 to update rcache hash algorithm from MD5 to SHA-256. It fixes issues on the FIPS environment without MD5 digest support

Implementation classes are applied cleanly.

Test changes are merged manually:

• Changes in the Proc.java are skipped because of no module support in JDK8
• "-Dsun.net.spi.nameservice.provider.1=ns,mock" option is added to rcache_usemd5.sh
• ReplayCacheTestProc.java is merged manually because of JDK-8190690 changes in JDK8

sun/security/krb5/auto tests passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8168518 needs maintainer approval

Issue

• JDK-8168518: rcache interop with krb5-1.15 (Bug - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/418/head:pull/418
$ git checkout pull/418

Update a local copy of the PR:
$ git checkout pull/418
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 418

View PR using the GUI difftool:
$ git pr show -t 418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/418.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (6b1491fa)

[alexeybakhtin]

Presubmit tests fail with unrelated errors:

• Windows debug build failure
• gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java test crashed on Linux

[bridgekeeper]

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[alexeybakhtin]

keep it open

[gnu-andrew]

Backport looks good to me and should allow 8u to work with caches from more modern mit-krb5 versions without breaking backwards compatibility (we are on 1.20 now)
The Proc.java change seems like it really should have been in a bug of its own as it's not related to this change at all. The other test changes are expected with the state of the tests in 8u. I take it all relevant tests passed with the backport? (saw your comment in the original post now)

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alexeybakhtin]

/approval request I'd like to backport this fix to 8u to support the new mit-krb5 version of rcache. These changes allow supporting of modern cache format without breaking backward compatibility.

[openjdk]

@alexeybakhtin usage: /approval [<id>] (request|cancel) [<text>]

[alexeybakhtin]

Backport looks good to me and should allow 8u to work with caches from more modern mit-krb5 versions without breaking backwards compatibility (we are on 1.20 now) The Proc.java change seems like it really should have been in a bug of its own as it's not related to this change at all. The other test changes are expected with the state of the tests in 8u. I take it all relevant tests passed with the backport? (saw your comment in the original post now)

Thank you for review

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8168518: The approval request has been approved.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8168518: rcache interop with krb5-1.15

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 3dc011b: 8323202: [8u] Remove get_source.sh and hgforest.sh
• abb4975: 8011180: Delete obsolete scripts
• cfed45d: 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache
• 818c53e: 8315042: NPE in PKCS7.parseOldSignedData
• f4f45e3: 8321060: [8u] hotspot needs to recognise VS2022
• 15e2c0b: 8322725: (tz) Update Timezone Data to 2023d
• 474c8c1: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• ... and 8 more: https://git.openjdk.org/jdk8u-dev/compare/d898d4018e0a16f2115f4b1cbf93eb5e653b789b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit dce5300.
Since your change was applied there have been 18 commits pushed to the master branch:

• 3dc011b: 8323202: [8u] Remove get_source.sh and hgforest.sh
• abb4975: 8011180: Delete obsolete scripts
• cfed45d: 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache
• 818c53e: 8315042: NPE in PKCS7.parseOldSignedData
• f4f45e3: 8321060: [8u] hotspot needs to recognise VS2022
• 15e2c0b: 8322725: (tz) Update Timezone Data to 2023d
• 474c8c1: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
• 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
• 552c686: Merge
• d4b472f: 8317547: Enhance TLS connection support
• ... and 8 more: https://git.openjdk.org/jdk8u-dev/compare/d898d4018e0a16f2115f4b1cbf93eb5e653b789b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeybakhtin Pushed as commit dce5300.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[johnshajiang]

The library path /test/lib looks missing.

[ianrichr]

I have made a PR for this exact problem: #478