8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

[ktakakuri]

I would like to backport
8248001: javadoc generates invalid HTML pages whose ftp:// links are broken.
There are minor differences regarding DocRoot, but otherwise this is a clean backport.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8248001 needs maintainer approval

Issue

• JDK-8248001: javadoc generates invalid HTML pages whose ftp:// links are broken (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/420/head:pull/420
$ git checkout pull/420

Update a local copy of the PR:
$ git checkout pull/420
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 420

View PR using the GUI difftool:
$ git pr show -t 420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/420.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9400ddc5)

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk]

@ktakakuri This pull request is now open

[openjdk]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 219 new commits pushed to the master branch:

• 8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
• 6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
• 8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
• 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
• 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
• 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• ... and 209 more: https://git.openjdk.org/jdk8u-dev/compare/2f81fb4b586097e5cb3e139e2131dd7a5b6312a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ktakakuri]

Could anyone review this backport please?
This is a simple fix, almost a clean backport.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

Can someone please review this backport?

[openjdk]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[ktakakuri]

/approval request There are minor differences regarding DocRoot, but otherwise this is a clean backport.
There is no risk, because the logic around the changes and the cause of the problem is the same as in jdk18.
Testing: test/langtools on Windows x86_64

[openjdk]

@ktakakuri
8248001: The approval request has been created successfully.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!