Skip to content

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jan 17, 2024

Sync jdk8u402-b06


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/421/head:pull/421
$ git checkout pull/421

Update a local copy of the PR:
$ git checkout pull/421
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 421

View PR using the GUI difftool:
$ git pr show -t 421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/421.diff

Alexey Bakhtin and others added 10 commits January 11, 2024 00:42
Reviewed-by: mbalao, andrew
Backport-of: 334b977259930368160db705c1f2feda0b0e8707
…t encode params correctly

Reviewed-by: sgehwolf, mbalao, andrew
Backport-of: 11e4a925bec3c1f79e03045d48def53188b655e6
Reviewed-by: mbalao, andrew
Backport-of: ef0ea85bf1398b73bd308ba2b395c917b449aa3b
Co-authored-by: Francisco Ferrari Bihurriet <fferrari@redhat.com>
Co-authored-by: Martin Balao Alonso <mbalao@redhat.com>
Reviewed-by: andrew
Reviewed-by: yan, andrew
Backport-of: 08980a0a60bc48c17eacd57fd2d7065ac2d986a8
Reviewed-by: mbalao, fferrari, andrew
Backport-of: 62ac93d145ca9fa1ab0c040533c62c42c202703a
Reviewed-by: mbalao, andrew
Backport-of: 2621f68c0672092254a52414705d0e916a3a3fbc
Reviewed-by: mbalao, andrew
Backport-of: ed1269b7410759e8fa0d97d85328f20d11ae8d9a
Reviewed-by: mbalao, andrew
Backport-of: 066482f9686ca81068f9386322afda8e73323f5e
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jan 17, 2024
@gnu-andrew
Copy link
Member Author

gnu-andrew commented Jan 18, 2024

VS2010 build seems to be broken because of the placing of the declarations of low, high and index in JDK-8314295. This is fixed by the private bug JDK-8317331: Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)" which was only applied to 21u: openjdk/jdk21u@4d07893

It doesn't make sense to fix this in the merge, but I've started the process to backport this.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

Going to push as commit 552c686.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2024
@openjdk openjdk bot closed this Jan 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@gnu-andrew Pushed as commit 552c686.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 18, 2024

Webrevs

@gnu-andrew
Copy link
Member Author

Backport process started for 17u: openjdk/jdk17u-dev#2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants