Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 24, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8323640 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/426/head:pull/426
$ git checkout pull/426

Update a local copy of the PR:
$ git checkout pull/426
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 426

View PR using the GUI difftool:
$ git pr show -t 426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/426.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 791b427f4410057cdcdf8fd8ea0dcce71f7dc513 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Jan 24, 2024
sendaoYan added 2 commits January 24, 2024 22:30
When the docker serivice work normally on the test machine, this test
will always fail. This test want to verify the API
jdk.internal.platform.Metrics.systemMetrics().getMemoryFailCount() work
normally or not. The API return memory allocate fail times in jvm. But,
before this PR, everytime it allocate 8M memory, the API has no chance
the catch the memory allocate fail, the jvm was killed by OOM. Change 8M
increments to 1K mean to avoid OOM killed for the jvm in docker
container.

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

⚠️ @sendaoYan This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@phohensee
Copy link
Member

GHA test failures look to be infrastructure issues.

@sendaoYan
Copy link
Member Author

This PR only change the testcase, the testcase change has been verified. Please review this PR.

@sendaoYan
Copy link
Member Author

/approval JDK-8323640 request

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
JDK-8323640: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 21, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
Your change (at version 8abebc0) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Windows GHA failures are unrelated.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

Going to push as commit 53e0826.
Since your change was applied there have been 15 commits pushed to the master branch:

  • a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  • b7bda28: 8325150: (tz) Update Timezone Data to 2024a
  • ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  • 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  • e926edc: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 9aabf22: 8270517: Add Zero support for LoongArch
  • dce5300: 8168518: rcache interop with krb5-1.15
  • 3dc011b: 8323202: [8u] Remove get_source.sh and hgforest.sh
  • abb4975: 8011180: Delete obsolete scripts
  • cfed45d: 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache
  • ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/552c6866d8ad71ef247b5303f78fa7a65506aea9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2024
@openjdk openjdk bot closed this Feb 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@phohensee @sendaoYan Pushed as commit 53e0826.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Windows GHA failures are unrelated.

@phohensee Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants