-
Notifications
You must be signed in to change notification settings - Fork 171
8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
|
👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
When the docker serivice work normally on the test machine, this test will always fail. This test want to verify the API jdk.internal.platform.Metrics.systemMetrics().getMemoryFailCount() work normally or not. The API return memory allocate fail times in jvm. But, before this PR, everytime it allocate 8M memory, the API has no chance the catch the memory allocate fail, the jvm was killed by OOM. Change 8M increments to 1K mean to avoid OOM killed for the jvm in docker container. Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
|
|
|
|
|
GHA test failures look to be infrastructure issues. |
|
This PR only change the testcase, the testcase change has been verified. Please review this PR. |
|
/approval JDK-8323640 request |
|
@sendaoYan |
|
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@sendaoYan |
|
/sponsor Windows GHA failures are unrelated. |
|
Going to push as commit 53e0826.
Your commit was automatically rebased without conflicts. |
|
@phohensee @sendaoYan Pushed as commit 53e0826. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@phohensee Thanks. |
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/426/head:pull/426$ git checkout pull/426Update a local copy of the PR:
$ git checkout pull/426$ git pull https://git.openjdk.org/jdk8u-dev.git pull/426/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 426View PR using the GUI difftool:
$ git pr show -t 426Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/426.diff
Webrev
Link to Webrev Comment