8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use #429

ktakakuri · 2024-01-25T07:32:51Z

Hi all,

This is a backport of JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use.
The JMXStartStopTest.java test failures reported in this issue also occur in JDK8.
This backport improves testing to use a dynamically allocated port.

testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java

With this fix alone, the test remains unstable.
Backporting with JDK-8035395 makes JMXStartStopTest.java more stable.

Thank you.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8035395 needs maintainer approval

Issue

JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use (Bug - P4 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/429/head:pull/429
$ git checkout pull/429

Update a local copy of the PR:
$ git checkout pull/429
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 429

View PR using the GUI difftool:
$ git pr show -t 429

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/429.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-01-25T07:34:03Z

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-01-25T07:35:45Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-01-25T07:38:42Z

Webrevs

00: Full (98cff0fe)

bridgekeeper · 2024-02-22T08:27:23Z

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

openjdk · 2024-02-29T22:52:59Z

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

phohensee · 2024-02-29T22:53:26Z

windows-x86 GHA builds seem broken due to unrelated issue.

openjdk · 2024-03-13T20:05:34Z

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

bfb1a7d: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
663ecc7: 8333126: Bump update version of OpenJDK: 8u432
db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
012f59c: 8316138: Add GlobalSign 2 TLS root certificates
7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
... and 58 more: https://git.openjdk.org/jdk8u-dev/compare/552c6866d8ad71ef247b5303f78fa7a65506aea9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

ktakakuri · 2024-04-03T12:47:21Z

/approval request I would like to backport this issue to 8u because the test fails also with jdk8.
There is no risk because it is a test-only fix.
Only with this fix , the test will not passed.
This backport is followed by a JDK-8066708 backport to stabilize the test.

openjdk · 2024-04-03T12:47:58Z

@ktakakuri
8035395: The approval request has been created successfully.

bridgekeeper · 2024-05-01T15:07:03Z

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-05-29T17:16:34Z

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

ktakakuri · 2024-05-30T01:27:00Z

/open

openjdk · 2024-05-30T01:28:18Z

@ktakakuri This pull request is now open

gnu-andrew

Backport looks good to me.

I see some differences with the 11u version, but this is because 8u got JDK-8044135 first, whereas this comes after this patch in 11u. JDK-8044135 removes test_13 and test_14 which were patched by 8035395 in 11u, and also alters the method signatures.

gnu-andrew · 2024-06-15T17:38:48Z

/approve yes

openjdk · 2024-06-15T17:39:35Z

@gnu-andrew
8035395: The approval request has been approved.

ktakakuri · 2024-06-16T23:52:27Z

/integrate

openjdk · 2024-06-16T23:53:03Z

@ktakakuri
Your change (at version 98cff0f) is now ready to be sponsored by a Committer.

phohensee · 2024-06-17T17:57:13Z

/sponsor

openjdk · 2024-06-17T17:58:02Z

Going to push as commit 6abb3f2.
Since your change was applied there have been 69 commits pushed to the master branch:

6838605: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
bfb1a7d: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
663ecc7: 8333126: Bump update version of OpenJDK: 8u432
db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
012f59c: 8316138: Add GlobalSign 2 TLS root certificates
... and 59 more: https://git.openjdk.org/jdk8u-dev/compare/552c6866d8ad71ef247b5303f78fa7a65506aea9...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-17T17:58:11Z

@phohensee @ktakakuri Pushed as commit 6abb3f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mrserb · 2024-08-16T00:24:53Z

jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java


            jcmd(CMD_STOP);
            jcmd(CMD_START,
                "jmxremote.ssl=false",
-                "jmxremote.port=" + port1
+                "jmxremote.port=" + pa.getPort1()
            );
            testConnect(port1);


fyi: change to port1 is missed, see #541

Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb

98cff0f

openjdk bot changed the title ~~Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb~~ 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use Jan 25, 2024

openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2024

ktakakuri mentioned this pull request Jan 25, 2024

8066708: JMXStartStopTest fails to connect to port 38112 #430

Closed

4 tasks

phohensee approved these changes Feb 29, 2024

View reviewed changes

openjdk bot added the approval label Apr 3, 2024

bridgekeeper bot closed this May 29, 2024

openjdk bot reopened this May 30, 2024

gnu-andrew approved these changes Jun 15, 2024

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 15, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 16, 2024

openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024

openjdk bot closed this Jun 17, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 17, 2024

mrserb reviewed Aug 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use #429

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use #429

ktakakuri commented Jan 25, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 25, 2024

openjdk bot commented Jan 25, 2024

mlbridge bot commented Jan 25, 2024

bridgekeeper bot commented Feb 22, 2024

openjdk bot commented Feb 29, 2024

phohensee commented Feb 29, 2024

openjdk bot commented Mar 13, 2024 •

edited

Loading

ktakakuri commented Apr 3, 2024

openjdk bot commented Apr 3, 2024

bridgekeeper bot commented May 1, 2024

bridgekeeper bot commented May 29, 2024

ktakakuri commented May 30, 2024

openjdk bot commented May 30, 2024

gnu-andrew left a comment

gnu-andrew commented Jun 15, 2024

openjdk bot commented Jun 15, 2024

ktakakuri commented Jun 16, 2024

openjdk bot commented Jun 16, 2024

phohensee commented Jun 17, 2024

openjdk bot commented Jun 17, 2024

openjdk bot commented Jun 17, 2024

mrserb Aug 16, 2024 •

edited

Loading

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use #429

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use #429

Conversation

ktakakuri commented Jan 25, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jan 25, 2024

openjdk bot commented Jan 25, 2024

mlbridge bot commented Jan 25, 2024

Webrevs

bridgekeeper bot commented Feb 22, 2024

openjdk bot commented Feb 29, 2024

phohensee commented Feb 29, 2024

openjdk bot commented Mar 13, 2024 • edited Loading

ktakakuri commented Apr 3, 2024

openjdk bot commented Apr 3, 2024

bridgekeeper bot commented May 1, 2024

bridgekeeper bot commented May 29, 2024

ktakakuri commented May 30, 2024

openjdk bot commented May 30, 2024

gnu-andrew left a comment

Choose a reason for hiding this comment

gnu-andrew commented Jun 15, 2024

openjdk bot commented Jun 15, 2024

ktakakuri commented Jun 16, 2024

openjdk bot commented Jun 16, 2024

phohensee commented Jun 17, 2024

openjdk bot commented Jun 17, 2024

openjdk bot commented Jun 17, 2024

mrserb Aug 16, 2024 • edited Loading

Choose a reason for hiding this comment

ktakakuri commented Jan 25, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading

mrserb Aug 16, 2024 •

edited

Loading