Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" #435

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jan 31, 2024

Hi all,

This pull request contains a backport of commit 4d078930 from the openjdk/jdk21u repository & the clean backport commit 4f80edf from 17u, also now in 11u. A new bug ID, JDK-8324184, had to be created as JDK-8317331, the original bug, is private.

The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers.

The backport fixes the VS2010 build which is broken by the placing of the declarations of low, high and index in JDK-8314295 after statements; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This positioning is disallowed by C90.

Adding -Werror=declaration-after-statement to the build flags replicated the failure on GCC 8. I will look at adding this to the build in a follow-up fix. It also needs a number of other changes to fix Linux-specific code which has never been built to this standard.

Backport was clean and built fine on GNU/Linux with GCC 8.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8324184 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/435/head:pull/435
$ git checkout pull/435

Update a local copy of the PR:
$ git checkout pull/435
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 435

View PR using the GUI difftool:
$ git pr show -t 435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/435.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4f80edfae10e83f2709f297a553d2128712e4b51 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

/approval request Additional change from the January security update which fixes new code introduced by a security patch to compile on older C compilers that require declarations to precede statements in a block. Patch applies clean and fixes the Windows x86 (VS2010) build failure we are seeing in GHA.

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@gnu-andrew
8324184: The approval request has been created successfully.

@gnu-andrew
Copy link
Member Author

Looks fine.

Thanks Severin. The Linux test failures seem to be sporadic gc failures unrelated to this change.

@openjdk openjdk bot added the approval label Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 31, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

Going to push as commit 4a69ad2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2024
@openjdk openjdk bot closed this Jan 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@gnu-andrew Pushed as commit 4a69ad2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants