Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 1, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8325096 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/436/head:pull/436
$ git checkout pull/436

Update a local copy of the PR:
$ git checkout pull/436
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 436

View PR using the GUI difftool:
$ git pr show -t 436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/436.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ac1cd3194910793b02e86c2c0dedaa321f137d4e 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Feb 1, 2024
The 3 certificates used in this test all expire on Feb 1st 2024. We should set date params for this test.

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@openjdk
Copy link

openjdk bot commented Feb 4, 2024

@sendaoYan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Mar 6, 2024

image

Backport of JDK-8325096

/approval request "This PR only change the testcase, the testcase change has been verified. Clean backport."

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan
8325096: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 6, 2024
@sendaoYan
Copy link
Member Author

clean backport

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • f63643b: 8268916: Tests for AffirmTrust roots
  • 1fad52d: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • d7ad5bf: 8159690: [TESTBUG] Mark headful tests with @key headful.
  • 0bf84a2: 8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails
  • 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
  • f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/4a69ad286bd13b2d0723df56d08c808cd968151c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 13, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@sendaoYan
Your change (at version 8f02c57) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 13, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

Going to push as commit fbb3392.
Since your change was applied there have been 24 commits pushed to the master branch:

  • f63643b: 8268916: Tests for AffirmTrust roots
  • 1fad52d: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • d7ad5bf: 8159690: [TESTBUG] Mark headful tests with @key headful.
  • 0bf84a2: 8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails
  • 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
  • f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/4a69ad286bd13b2d0723df56d08c808cd968151c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2024
@openjdk openjdk bot closed this Mar 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@jerboaa @sendaoYan Pushed as commit fbb3392.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

@jerboaa Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants