Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8011180: Delete obsolete scripts #438

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Feb 8, 2024

This backport removes some obsolete scripts.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8011180 needs maintainer approval

Issue

  • JDK-8011180: Delete obsolete scripts (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/438/head:pull/438
$ git checkout pull/438

Update a local copy of the PR:
$ git checkout pull/438
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 438

View PR using the GUI difftool:
$ git pr show -t 438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/438.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e0966b6cfaf37d3a543782ee65427185b1ac13c 8011180: Delete obsolete scripts Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@zzambers
Copy link
Contributor Author

zzambers commented Feb 8, 2024

/approval request Just removes obsolete scripts, which are not used anymore

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@zzambers
8011180: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 8, 2024
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@gnu-andrew
8011180: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8011180: Delete obsolete scripts

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 9, 2024
@zzambers
Copy link
Contributor Author

@gnu-andrew thanks
/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

Going to push as commit abb4975.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2024
@openjdk openjdk bot closed this Feb 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@zzambers Pushed as commit abb4975.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants