Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8146215: (fs) java/nio/file/Files/probeContentType/Basic.java failed frequently on Solaris-sparc with Unexpected type: text/plain #44

Closed
wants to merge 1 commit into from

Conversation

akashche
Copy link
Contributor

@akashche akashche commented Apr 20, 2022

Backport of a NIO fix.

Original commit on jdk9: https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/44bb7c7997ca

Patch does not apply cleanly, differences from original commit: paths reshuffling, copyright year in
AbstractFileTypeDetector.java, list of issues numbers changed and checkOSXContentTypes() function removed in Basic.java test.

Related mailing list threads:

https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012050.html
https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-October/014321.html

Testing:

  • jtreg:java/nio/file/Files/
  • jtreg:java/net/URLConnection/

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8146215: (fs) java/nio/file/Files/probeContentType/Basic.java failed frequently on Solaris-sparc with Unexpected type: text/plain

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/44/head:pull/44
$ git checkout pull/44

Update a local copy of the PR:
$ git checkout pull/44
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/44/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 44

View PR using the GUI difftool:
$ git pr show -t 44

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/44.diff

…frequently on Solaris-sparc with Unexpected type: text/plain
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2022

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 522e112b4a4f5c794aa3c450c019d95b2661b2b0 8146215: (fs) java/nio/file/Files/probeContentType/Basic.java failed frequently on Solaris-sparc with Unexpected type: text/plain Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 20, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

@akashche This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant